Skip to content

Commit

Permalink
Review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ry committed Dec 6, 2018
1 parent 0239104 commit 902cb90
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
10 changes: 1 addition & 9 deletions libdeno/binding.cc
Expand Up @@ -182,25 +182,17 @@ void PromiseRejectCallback(v8::PromiseRejectMessage promise_reject_message) {
d->pending_promise_map_.emplace(std::piecewise_construct,
std::make_tuple(promise_id),
std::make_tuple(d->isolate_, error));
// rejectMap.set(promise, (error as Error).stack ||
// "RejectWithNoHandler");
break;

case v8::kPromiseHandlerAddedAfterReject:
// unhandled event cancelled
d->pending_promise_map_.erase(promise_id);
// rejectMap.delete(promise);
break;

case v8::kPromiseRejectAfterResolved:
// Should not warn. See #1272
// d->pending_promise_events_++;
break;

case v8::kPromiseResolveAfterResolved:
// d->pending_promise_events_++;
// error is string here
// otherErrorMap.set(promise, `Promise warning: ${error as string}`);
// Should not warn. See #1272
break;

default:
Expand Down
2 changes: 1 addition & 1 deletion src/main.rs
Expand Up @@ -73,7 +73,7 @@ impl log::Log for Logger {

fn print_err_and_exit(err: js_errors::JSError) {
// TODO Currently tests depend on exception going to stdout. It should go
// to stderr.
// to stderr. https://github.com/denoland/deno/issues/964
println!("{}", err.to_string());
std::process::exit(1);
}
Expand Down

0 comments on commit 902cb90

Please sign in to comment.