Reorganize Payment Gateway Structure and Fix Payment Method Creation #24
Conversation
| assert Proxy.changeset(%Proxy{}, %CreditCard{}) == expectation | ||
| changeset = CreditCard.changeset(%CreditCard{}, params) | ||
| expectation = cast(%Proxy{}, %{data: params}, [:data]) | ||
| assert Proxy.changeset(%Proxy{}, %CreditCard{}) == Map.merge(expectation, %{ |
There was a problem hiding this comment.
Line is too long (max is 80, was 82).
| |> Repo.insert! | ||
|
|
||
| gateway = %PaymentGateway{} | ||
| |> PaymentGateway.changeset(%{type: "stripe", external_id: "cus_123", user_id: user.id}) |
There was a problem hiding this comment.
Line is too long (max is 80, was 96).
| |> Repo.insert! | ||
|
|
||
| gateway = %PaymentGateway{} | ||
| |> PaymentGateway.changeset(%{type: "stripe", external_id: "cus_123", user_id: user.id}) |
There was a problem hiding this comment.
Line is too long (max is 80, was 96).
| }) | ||
| |> Ryal.repo.insert! | ||
|
|
||
| result = Stripe.create(:credit_card, credit_card.proxy.data, bypass_endpoint(bypass)) |
There was a problem hiding this comment.
Line is too long (max is 80, was 91).
|
|
||
| defp random_id do | ||
| :rand.uniform * 10_000_000_000 | ||
| |> round |
There was a problem hiding this comment.
Pipe chain should start with a raw value.
We now pattern match based on domain, not by gateway provider. This way, when developing payment gateways, we can keep private functions and configuration specific to a single module.
BenMorganIO
force-pushed
the
credit-cards-and-stripe
branch
from
c185cd3
to
2f80198
Compare
BenMorganIO
changed the title
| end | ||
|
|
||
| %PaymentGateway{} | ||
| |> PaymentGateway.changeset(%{type: "stripe", external_id: "cus_123", user_id: user.id}) |
There was a problem hiding this comment.
Line is too long (max is 80, was 94).
| @stripe_api_key Map.get(Ryal.payment_gateways(), :stripe) | ||
| @stripe_base "https://#{@stripe_api_key}:@api.stripe.com" | ||
|
|
||
| @spec create(atom, Ecto.Schema.t, String.t) :: {:ok, String.t} |
There was a problem hiding this comment.
I need to remove the need for an Ecto.Schema.t and use either multiple args or a map instead.
There was a problem hiding this comment.
At this level I agree. We shouldn't tie gateway usage to Ecto dependencies....Unless we are comitted to building on the Phoenix stack instead of a more general approach.
There was a problem hiding this comment.
I'm good with sticking to Ecto. However, we don't really need Phoenix so much as we need Plug. To me, Ryal, ATM, will always require storage. It's up to the user if they want to mount the API. Ryal, however, would expect to be able to store data.
Unless, of course, we move the logic for Ryal into another dependency. But that's a longer-term goal. We need Ryal working first.
There was a problem hiding this comment.
Ok let's ship it 
and keep an eye on these dependencies as the code base grows.
This PR has a lot of changes in it.
I've gone and changed up how payment gateways are developed. We want to have them split off by their type and not their domain logic. This way we can isolate all of that per payment gateway.
I've added some work for creating credit cards. There's still lots more to do, but hey, at least we can create credit cards now. They are also tied to a specific customer.
When configuring fallback gateways, we don't need to explicitly ask for it anymore. We can now just ask the person for a list of keys and values.
Payment methods weren't fully working. They're now fully working with the embeds.