Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError when css_files is None with Sphinx 1.6 #160

Closed
jaraco opened this issue May 17, 2017 · 3 comments
Closed

TypeError when css_files is None with Sphinx 1.6 #160

jaraco opened this issue May 17, 2017 · 3 comments

Comments

@jaraco
Copy link

jaraco commented May 17, 2017 •
edited
Loading

Using Sphinx 1.6.1, running quickstart, then configuring sphinx_bootstrap_theme according to the README, the docs fail to build with this error:

Exception occurred:
  File "/Users/jaraco/.envs/sphinx/lib/python3.6/site-packages/sphinx_bootstrap_theme/bootstrap/layout.html", line 40, in top-level template code
    {% set css_files = css_files + theme_css_files + bootswatch_css_custom %}
TypeError: unsupported operand type(s) for +: 'NoneType' and 'list'

This issue emerged as part of the Sphinx 1.6 release. Pinning to Sphinx 1.5.6 works around the issue.
@jaraco
Copy link
Author

jaraco commented May 17, 2017

I've pushed a minimal project to this repo for easy testing.

@ryan-roemer
Copy link
Owner

Hey @jaraco !!!!

How's it going?

Anyhoo, to the issue at hand -- I'm working on it at #159 (comment) The main issue's fixed, but I still need to support "adding extra CSS" in some documented, idiomatic way...

Head on over there!

ryan-roemer added a commit that referenced this issue May 17, 2017
@ryan-roemer
* Fix css_files breakage from Sphinx 1.6+ update.
0ecb183 
  `#158 <https://github.com/ryan-roemer/sphinx-bootstrap-theme/pull/158>`_,
  `#160 <https://github.com/ryan-roemer/sphinx-bootstrap-theme/pull/160>`_.

* **Breaking Change**: Remove ``bootswatch_css_custom`` override, and instead opt for documenting idiomatic Sphinx-version specific generic overrides for custom CSS.
@jaraco
Copy link
Author

jaraco commented May 17, 2017

How's it going?

Quite well, and was pleased to bump into you here, even to create work for you. Glad you were essentially already on it. Hope you're well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaraco @ryan-roemer