Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachments? #26

Closed
cj opened this issue Jan 5, 2012 · 4 comments
Closed

Attachments? #26

cj opened this issue Jan 5, 2012 · 4 comments

Comments

@cj
Copy link

cj commented Jan 5, 2012

Hi,

Is it possible to show attachments with letter opener? Right now they don't show, so I have no clue if they worked.

Many thanks
@Nkburdick
Copy link

@cj, Do your attachments not show up at all? In mine they show up as gibberish.

@cj
Copy link
Author

cj commented Feb 1, 2012

@Nkburdick correct, they don't show up at all... not even as gibberish :/

@maletor
Copy link

maletor commented Feb 13, 2012

Same.

@alexdreher alexdreher mentioned this issue Mar 30, 2012
Closed
cj added a commit to cj/letter_opener that referenced this issue May 15, 2012
@cj
Merge pull request ryanb#36 from davidcornu/master
15b1a15 
Attachment Support (ryanb#26)

* davidcornu/master:
  Don't recreate files if already present
  Added test for attachments
  mail.attachments returns an array which evaluates to true, changed to a size check
  Forgot a pixel
  Always show attachment section
  only show rich/plain links if the parts exist
  Use mail's text_part and html_part methods to avoid rendering attachments as plain text
  Turns out there was a good reason for that
  Remove height constraint from headers and add more padding so more attachments can fit
  Better styling
  Require 'uri' for escaping filenames
  Tentative attachment support
@ryanb
Copy link
Owner

ryanb commented Oct 1, 2012

Closing this since there is now pull request #36

@ryanb ryanb closed this as completed Oct 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ryanb @cj @maletor @Nkburdick