Added a Rails Engine to show the letters if you are not running locally #12

Closed
wants to merge 1 commit into
from

Projects

None yet

5 participants

@alexrothenberg

What do you think of adding a Rails Engine to this gem so it can be used on a non-local server where launchy wont work? This engine adds a route so http://your.app.com/letter_opener will show a very simple inbox and each letter can also be viewed.

I'm not really sure how to test an engine so I only wrote a spec for the model and unfortunately have none for the controller or routes.

This gem is a great idea and came just when I needed it!

@ryanb
Owner
ryanb commented Sep 13, 2011

This is something I would definitely like to do. I want to first focus on bug fixes and minor improvements, but once that is solid I'll pull this in. Thanks!

@alexrothenberg

Sounds good. I'll sit tight until then.

@krisleech

I'm using the branch from @alexrothenberg on staging and I can confirm it works well.

@ryanb
Owner
ryanb commented Oct 1, 2012

Closing this since I want to keep letter_opener simple and lightweight. However I would love to see this as a separate gem. Maybe called "remote_letter_opener"? It could use this gem as a dependency and just override the delivery method behavior and add an engine.

@ryanb ryanb closed this Oct 1, 2012
@ryanb ryanb referenced this pull request Oct 1, 2012
Closed

Error when run in vagrant vm #47

@fgrehm
Contributor
fgrehm commented Jan 4, 2013

Hey guys, I've just release a pretty basic gem to do that: https://github.com/fgrehm/letter_opener_web

@nashby
Collaborator
nashby commented Jan 4, 2013

Awesome! Could you please add a note about this gem to letter_opener's
README?

On Fri, Jan 4, 2013 at 5:41 PM, Fabio Rehm notifications@github.com wrote:

Hey guys, I've just release a pretty basic gem to do that:
https://github.com/fgrehm/letter_opener_web


Reply to this email directly or view it on GitHubhttps://github.com/ryanb/letter_opener/pull/12#issuecomment-11884801.

@fgrehm
Contributor
fgrehm commented Jan 4, 2013

Done #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment