Skip to content
This repository has been archived by the owner on Dec 12, 2021. It is now read-only.

add ie8 support #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add ie8 support #61

wants to merge 1 commit into from

Conversation

ascrazy
Copy link

@ascrazy ascrazy commented Sep 3, 2012

No description provided.

@ndan ndan mentioned this pull request Oct 17, 2012
@nfm
Copy link

nfm commented Feb 4, 2013

Hi @dbanck, the Microsoft KB article (http://support.microsoft.com/kb/927917) seems to say it's an IE7 issue - are you able to confirm whether you've had the same error for IE8?

Unfortunately we can't move the appendChild into onload - appending the script is what makes it start loading in the first place. I'm looking into the jQuery pattern of handling this, which I believe is to avoid the bug you've reported - they use document.head.insertBefore(script, document.head.firstChild) instead.

I will check back soon with some more information about this pull request once I've done my homework!

@JohnAmican
Copy link

Is this still active?

@wakiki
Copy link

wakiki commented Jun 20, 2013

I confirm it's still not working in IE7, and I'm getting this error:

HTML Parsing Error: Unable to modify the parent container element before the child element is closed (KB927917)

IE8 works fine.

Is there any progress on fixing this for IE6/7 (I know we shouldn't support these old browsers, but we have no choice... sigh)

@davidlesches
Copy link

I was having the parse error with IE8, I corrected it using this -
http://www.jspatterns.com/the-ridiculous-case-of-adding-a-script-element/

i.e. I replaced doc.documentElement.appendChild(script); with

var first = document.getElementsByTagName('script')[0];
first.parentNode.insertBefore(script, first);

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants