Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

add ie8 support #61

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants

ascrazy commented Sep 3, 2012

No description provided.

Alexander Shahorsky add ie8 support 5bcfb4f

@ndan ndan referenced this pull request Oct 17, 2012

Open

It doesn't work in IE8 #57

nfm commented Feb 4, 2013

Hi @dbanck, the Microsoft KB article (http://support.microsoft.com/kb/927917) seems to say it's an IE7 issue - are you able to confirm whether you've had the same error for IE8?

Unfortunately we can't move the appendChild into onload - appending the script is what makes it start loading in the first place. I'm looking into the jQuery pattern of handling this, which I believe is to avoid the bug you've reported - they use document.head.insertBefore(script, document.head.firstChild) instead.

I will check back soon with some more information about this pull request once I've done my homework!

Is this still active?

wakiki commented Jun 20, 2013

I confirm it's still not working in IE7, and I'm getting this error:

HTML Parsing Error: Unable to modify the parent container element before the child element is closed (KB927917)

IE8 works fine.

Is there any progress on fixing this for IE6/7 (I know we shouldn't support these old browsers, but we have no choice... sigh)

I was having the parse error with IE8, I corrected it using this -
http://www.jspatterns.com/the-ridiculous-case-of-adding-a-script-element/

i.e. I replaced doc.documentElement.appendChild(script); with

var first = document.getElementsByTagName('script')[0];
first.parentNode.insertBefore(script, first);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment