JIT Changes #4

Merged
merged 6 commits into from Oct 9, 2012

2 participants

@mgangadhar

Ryan,
Primarily added text area to input additional attributes on the Response Request page and another text area to format the SAML response to make it more readable on the Target Poster page. Please let me know if you have any questions.

Thanks,
Mahanthi

@ryanbrainard ryanbrainard and 1 other commented on an outdated diff May 3, 2012
...ava/axiom/saml/idp/Saml2AbstractAssertionFactory.java
@@ -168,7 +171,7 @@ protected Subject buildSubject(String nameIdentifierValue)
protected abstract Subject buildSubject();
protected AttributeStatement buildAttributeStatement(
- List<Attribute> additionalAttributes) throws IllegalStateException {
+ List<Attribute> addAttributes) throws IllegalStateException {
@ryanbrainard
Owner

This is confusing having both an additionalAttributes and addAttributes. In addition, addAtrributes sounds like a verb, not a noun. Beyond just renaming the var, this probably should be rafactored to have the injection of both kinds of additional attributes be cleaner. I know the original code was a bit messy though :(

@ryanbrainard
Owner

Also, what happens if someone used the form for attributes, but also set the same thing in free form JIT field? Does it matter if they are using subject or attribute for user id? See comment below about testing.

Just a thought, if the user selects "Attribute" radio button, what if we disable Username or Federated ID text field and basically force the user to add the attribute in the Additional Attributes text area. If we go that route, we can remove the Attribute Name and Format fields from the UI. In essence we would have all attributes defined in the additional attributes area and have one method to construct the attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@ryanbrainard ryanbrainard commented on the diff May 3, 2012
src/main/resources/axiom/web/package.properties
@@ -63,7 +65,8 @@ label.saml.idp.SAMLResponse=Base 64 Encoded SAML Response
label.saml.idp.target=Target
label.saml.idp.RelayState=Relay State
label.saml.idp.RelayStateOrStartURL=Start URL / Relay State
-
+label.saml.idp.FormattedResponse=A more readable SAML response
@ryanbrainard
Owner

This is on a button, so should be in the form of a verb phrase (e.g. Format SAML Response)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@ryanbrainard
Owner

Are there tests for this change?

@mgangadhar
@ryanbrainard ryanbrainard merged commit 1e7d146 into ryanbrainard:master Oct 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment