fix(starboard): move type checking logic inside conditional

ryanccn · May 23, 2023 · 3a8a6e4 · 3a8a6e4
1 parent dcbadcb
commit 3a8a6e4
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/features/starboard.ts b/src/features/starboard.ts
@@ -100,13 +100,12 @@ const updateStarboard = async (message: Message) => {
 
   let existingMessageId = await get(['starboard', message.id, 'message']);
 
-  if (typeof existingMessageId !== 'string') {
-    throw new Error(`Message ID found for ${message.id} is not a string!`);
-  }
-
-  existingMessageId = existingMessageId.slice(1);
-
   if (existingMessageId) {
+    if (typeof existingMessageId !== 'string') {
+      throw new Error(`Message ID found for ${message.id} is not a string!`);
+    }
+    existingMessageId = existingMessageId.slice(1);
+
     const existingResolvedMessage = await starboard.messages
       .fetch({ around: existingMessageId, limit: 3 })
       .then((res) => res.find((k) => k.id === existingMessageId));