Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing #3

Closed
johntom opened this issue Apr 8, 2014 · 7 comments
Closed

testing #3

johntom opened this issue Apr 8, 2014 · 7 comments

Comments

@johntom
Copy link

johntom commented Apr 8, 2014

Hi Ryan,
I'm testing your repository as I'm planning on upgrading my apps to sails 0.10 so I'm putting my app through some test and decided to see how I might apply some your concepts. I'd like to create a few uses with credentials but I'm having some issues.

I register test with your pre-assined password and john with password 123456 but can't use those credentials to login. As I don't see the password begin stored in any format I'm not sure what I can be doing wrong.

The console reports and error after adding a new message "invalid user 'publishAdd(id,alias,idAdded.... error"

When starting the app a flicker display problem occurs.

I tried to use Mongo as the storage but can't get past the login although the messages are stored after I register a new name.

TIA
John

@ryancp
Copy link
Owner

ryancp commented Apr 9, 2014

Hi John, thanks for the description of your problem. The issue you are experiencing is due to the fact that your password must be at least 8 characters in length. I plan on adding better error handling and user notification for things like this.

But try that and keep us updated on if it solves your problem.

@johntom
Copy link
Author

johntom commented Apr 9, 2014

Hi Ryan,

Thanks, that did it. Perhaps a label on the register form would help! I will update you on any other issues.

John

From: ryancp [mailto:notifications@github.com]
Sent: Wednesday, April 09, 2014 12:46 AM
To: ryancp/sailng
Cc: John R. Tomaselli
Subject: Re: [sailng] testing (#3)

Hi John, thanks for the description of your problem. The issue you are experiencing is due to the fact that your password must be at least 8 characters in length. I plan on adding better error handling and user notification for things like this.

But try that and keep us updated on if it solves your problem.


Reply to this email directly or view it on GitHub #3 (comment) . https://github.com/notifications/beacon/1877376__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxMjYzNzk0NywiZGF0YSI6eyJpZCI6Mjk1NzIzOTh9fQ==--fd3ac501b86c32529bcc2a6b5a9a805744547807.gif


No virus found in this message.
Checked by AVG - www.avg.com
Version: 2014.0.4355 / Virus Database: 3722/7312 - Release Date: 04/07/14

@johntom
Copy link
Author

johntom commented Apr 9, 2014

Hi,
Just tried to replace "sails-disk":"~0.10.0" with "sails-mongo": "^0.10.0-rc2"

  1. At first, things seemed fine. I created a user and password and viewed user and passport entries in bsSample (my mongo database) see below.
  2. After registration the user is not logged in. Console reports currently logged in user is: john but chrome reports error below and I can't login.

John

Uncaught SyntaxError: Unexpected token ILLEGAL home:42
XHR finished loading: "http://localhost:1337/socket.io/1/?__sails_io_sdk_version=0.10.0&__sails_io_sdk_platform=browser&__sails_io_sdk_language=javascript&t=1397060244798". sails.io.js:2 |>

mongodb
user
{
"username" : "john",
"email" : "jrt@gtz.com",
"first_name" : "John",
"createdAt" : ISODate("2014-04-09T16:23:22.433Z"),
"updatedAt" : ISODate("2014-04-09T16:23:22.433Z"),
"_id" : ObjectId("534573fa00cd0e40406a57ce")
}
passport
{
"protocol" : "local",
"password" : "$2a$10$3ZFNShHU1KoFjdYuZ/2h..eiGPkdAq1mGpuc7TwO.DZI7sG2kJCZ6",
"user" : "534573fa00cd0e40406a57ce",
"createdAt" : ISODate("2014-04-09T16:23:23.079Z"),
"updatedAt" : ISODate("2014-04-09T16:23:23.079Z"),
"_id" : ObjectId("534573fb00cd0e40406a57cf")
}

@ryancp
Copy link
Owner

ryancp commented Apr 10, 2014

Glad you got it working. I will create a new issue that describes adding validation messages for the registrations screen so things like < 8 character passwords will be called out to the user on registering. Although, I have been looking at https://github.com/zeMirco/lockit and would like to integrate that project with Sailng.

As for your most recent comment, I just pushed a fix that should resolve the issue you see about the Unexpected token ILLEGAL error.

Pull down the latest commit and see if that helps.

@ryancp ryancp closed this as completed Apr 10, 2014
@johntom
Copy link
Author

johntom commented Apr 10, 2014

That fixed it, you the man! When I have a nice working example, I will fork so other's may share. Are you looking to replace brypt/passport with lockit?

From: ryancp [mailto:notifications@github.com]
Sent: Thursday, April 10, 2014 12:34 AM
To: ryancp/sailng
Cc: John R. Tomaselli
Subject: Re: [sailng] testing (#3)

Glad you got it working. I will create a new issue that describes adding validation messages for the registrations screen so things like < 8 character passwords will be called out to the user on registering. Although, I have been looking at https://github.com/zeMirco/lockit and would like to integrate that project with Sailng.

As for your most recent comment, I just pushed a fix that should resolve the issue you see about the Unexpected token ILLEGAL error.

Pull down the latest commit and see if that helps.


Reply to this email directly or view it on GitHub #3 (comment) . https://github.com/notifications/beacon/1877376__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxMjcyMzYxNSwiZGF0YSI6eyJpZCI6Mjk1NzIzOTh9fQ==--9c6b0459b2ac63b93e68d2af55480a451a2cf5c0.gif


No virus found in this message.
Checked by AVG - www.avg.com
Version: 2014.0.4355 / Virus Database: 3722/7312 - Release Date: 04/07/14

@ryancp
Copy link
Owner

ryancp commented Apr 11, 2014

Good to hear it is working. Lockit looks intriguing and I would definitely like to see if it is fairly straightforward to integrate. That just takes some time. I know there is an issue on the lockit project to work with Waterline: zemirco/lockit#5

@johntom
Copy link
Author

johntom commented Apr 17, 2014

Hi Ryan,

Thanks for all your help and I just forked a repo of my changes.

new repo https://github.com/johntom/sailng.

John

From: ryancp [mailto:notifications@github.com]
Sent: Thursday, April 10, 2014 12:34 AM
To: ryancp/sailng
Cc: John R. Tomaselli
Subject: Re: [sailng] testing (#3)

Closed #3 #3 .


Reply to this email directly or view it on GitHub #3 . https://github.com/notifications/beacon/1877376__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxMjcyMzYxNiwiZGF0YSI6eyJpZCI6Mjk1NzIzOTh9fQ==--62d0c6bb72985c4af2a08dcbc293f238e9392978.gif


No virus found in this message.
Checked by AVG - www.avg.com
Version: 2014.0.4355 / Virus Database: 3722/7312 - Release Date: 04/07/14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants