Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You do not have permission to execute this module - ProcessPageSearch #520

Closed
adrianbj opened this issue Jun 16, 2014 · 5 comments
Closed

Comments

@adrianbj
Copy link

Hey Ryan,

It looks like the newly added checks for module permissions around line#457 of Modules.php (2c0762d#diff-995c5c9ce48d4bff459f52363c6e190eR457)

has caused an issue for calls when not logged in with the Pages Web Service module because ProcessPageSearch requires page-edit permissions. Not sure if this affects any other modules.

More details here: https://processwire.com/talk/topic/1654-module-pages-web-service-servicepages/?p=65380

which also includes another issue with the Pages Web Service module and $_GET['it']

ryancramerdesign added a commit that referenced this issue Jun 21, 2014
…rray can be specified to modify behavior. Change motivated by issue #520 which identifies the need to have modules loaded without permission checks.
@ryancramerdesign
Copy link
Owner

Thanks Adrian, I have fixed that issue by adding a new getModule($key, $options) method to the Modules class that lets you retrieve a module with $options. In this case an option called 'noPermissionCheck'. The ServicePages module has been updated to use the new method (when available).

@adrianbj
Copy link
Author

Thanks Ryan, all seems to be working great now and that new option should come in handy elsewhere too. I have made some additional comments about the "it" variable issue in the module forum thread.

@adrianbj
Copy link
Author

Ryan, looks like this issue might have returned:https://processwire.com/talk/topic/1654-pages-web-service-servicepages/?p=75258

@isellsoap
Copy link
Collaborator

@adrianbj Is this still an issue?

@adrianbj
Copy link
Author

adrianbj commented Oct 1, 2016

Honestly don't know, but Ryan recently unpublished the module that was broken by this core issue anyway - I don't know why, but I guess that makes it a non-issue :)

@adrianbj adrianbj closed this as completed Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants