Circular reference mitigation

[KeeneState]

Hi Ryan, we ran into a series of out of memory errors during page saves after a page was mistakenly self-referenced, e.g. $page->FieldtypePage[Select] = $page. This took care of it, though I'm not certain it's the best place to prevent it.

---

Adding self check to prevent circular reference on page save leading to OOM. This will occur in cases where a Page contains a Page select input, with $this selected. While this would likely be due to a administration mistake or the result of poor template design, it will white-screen any page save containing the field as it attempts to uncache.

[apeisa]

I did hit this same problem with my https://github.com/apeisa/UserGroups module, where self-reference is required and intended.

[KeeneState]

Antti, I deleted my fork and Ryan's response to this pull request was removed along with it - still getting used to some of the eccentricities of github. Ryan actually had an improved version of the patch he was going to apply to dev.

[apeisa]

Thanks for letting me know @KeeneState

@ryancramerdesign is this fix already in place in dev?

[ryancramerdesign]

A fix was put on dev, but I'm not positive I committed it in full–since
working with your module, I've backtracked and have been trying to get it
working in full with circular references, rather than prevent them. I'm not
there yet, but do think we'll get there.

On Fri, Dec 6, 2013 at 4:04 PM, Antti Peisa notifications@github.comwrote:

Thanks for letting me know @KeeneState https://github.com/KeeneState

@ryancramerdesign https://github.com/ryancramerdesign is this fix
already in place in dev?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/258#issuecomment-30029298
.

[apeisa]

Thanks for the information ryan. Hopefully this get's fixed soon. I got project in hand where page based permission would be a lifesaver.