Workaround for sharpening with buggy PHP versions #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP versions 5.5.9 and 5.5.10 have a broken function imageconvolution in GD-lib
I have found this myself while building a unit testcase for images :) This bug is reproduceable: If you have a loop with mixed png images (with and without transparency), the value of the first image was stored and returned for all others. This could result in transparent images become black background or in not transparent images get not sharpened! (@martijn: I think it was this one you run into earlier) When writing this function I want avoid to open the file multiple times and thought to store it in a static variable is a good idea. But also I've thought it is static for the lifetime of one ImageSizer instance, but it seems that it is permanent for all following ImageSizer instances. (Learned something new today)
|
Is obsolete because I have merged this together with the new USM sharpening method in #445 |
|
Oh damn, I have opened it. But that was wrong. Sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP versions 5.5.9 and 5.5.10 have a broken function imageconvolution in GD-lib