Handle state objects which are Maps #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have confirmed that for both TypeScript and Flow that type |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue in #49 by checking whether the state object is a Map. What this PR does not cover is using Immutable JS without combineReducers, however I think this is a more specialised case and would be best handled as an extension of some kind, or a forked version of the project.
I am new to Flow so you may want to look at annotating the state argument, I had a look at defining a Map containing a LocaleState object however Flow didn't seem to like it. It does not however complain when not defining a Map type, probably because Map is in most respects just an object. I am happy to look further into this.