fix: issue with scheduled-volume-snapshot label length

ryaneorth · Dec 20, 2023 · 65214d7 · 65214d7
1 parent 81fc1e4
commit 65214d7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -10,7 +10,7 @@ RUN apt-get update \
  && apt-get upgrade -y \
  && apt-get clean \
  && rm -rf /var/lib/apt/lists/* \
- && pip install --no-cache-dir --upgrade pip==22.1.2 setuptools==67.1.0 \
+ && pip install --no-cache-dir --upgrade pip==23.3 setuptools==67.1.0 \
  && pip install --no-cache-dir -r requirements.txt \
  && rm requirements.txt
 

diff --git a/snapshotter.py b/snapshotter.py
@@ -81,13 +81,16 @@ def new_snapshot_needed(scheduled_snapshot, existing_snapshots):
 
 
 def create_new_snapshot(scheduled_snapshot):
-    scheduled_snapshot_name = scheduled_snapshot.get('metadata').get('name')
+    scheduled_snapshot_name = scheduled_snapshot.get('metadata', {}).get('name')
     pvc_name = scheduled_snapshot.get('spec', {}).get('persistentVolumeClaimName')
     new_snapshot_name = f'{scheduled_snapshot_name}-{str(int(time.time()))}'
     new_snapshot_namespace = scheduled_snapshot.get('metadata', {}).get('namespace')
+    scheduled_snapshot_name_label = scheduled_snapshot_name
+    if len(scheduled_snapshot_name) > 63:
+        scheduled_snapshot_name_label = scheduled_snapshot_name[:63]
     new_snapshot_labels = {
         **scheduled_snapshot.get('spec', {}).get('snapshotLabels', {}),
-        'scheduled-volume-snapshot': scheduled_snapshot.get('metadata', {}).get('name')
+        'scheduled-volume-snapshot': scheduled_snapshot_name_label
     }
     logging.info(f'Creating snapshot {new_snapshot_name} in namespace {new_snapshot_namespace}')
     volume_snapshot_body = {