Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncation for schedule volume snapshot label in child VolumeSnapshot object #25

Closed
bsgrigorov opened this issue Dec 20, 2023 · 1 comment

Comments

@bsgrigorov
Copy link
Contributor

When the schedule volume snapshot object is used to create a VolumeSnapshot, it uses its name as one of the labels. Labels can be max 63 chars, but object names can be longer.

Thus creation of the VolumeSnapshot would fail. We need to truncate the scheduled-volume-snapshot name when used in the label of VolumeSnapshot:
https://github.com/ryaneorth/k8s-scheduled-volume-snapshotter/blob/main/snapshotter.py#L90

@ryaneorth
Copy link
Owner

Thanks for reporting this issue @bsgrigorov! Fixed in the latest release: v0.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants