Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confused? #5

Open
ultraCAO opened this issue May 4, 2021 · 2 comments
Open

Confused? #5

ultraCAO opened this issue May 4, 2021 · 2 comments

Comments

@ultraCAO
Copy link

ultraCAO commented May 4, 2021

any idea why is it doing this? it works fine if I crop out the top part of the ColorChecker Passport. and only leaving the standard 24 patches.

confused
confused2
confused3

@ryanfb
Copy link
Owner

ryanfb commented May 5, 2021

I think the original code works best when the colorchecker isn't taking up the full frame. Probably at this point, a ML-based rewrite would be more robust and perform better.

@ultraCAO
Copy link
Author

ultraCAO commented May 5, 2021

I think the original code works best when the colorchecker isn't taking up the full frame. Probably at this point, a ML-based rewrite would be more robust and perform better.

Those images are cropped to show just the ColorChecker with the output, they were full frame with the ColorChecker taking up about 1/8 to 1/6 of the full frame.
Also, it didn't work with a 16-bit file. in the code path at some point, it wants 8-bit only.
An ML-based one would be lovely. Let me know if you going to start a repo for that. I'll help with the model training.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants