-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loadProps Nirvana #34
Comments
Sure you're on the latest version? This was fixed a while back. |
Yes, I am. If it helps, i uploaded the repo at https://github.com/ChiefORZ/super-sexy-react/tree/feature/async-props |
#40 fixed it! |
Yessss!
|
this is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I discovered that the
static loadProps
method has to be defined in all Components, otherwise the async-props will not receive an callback and update - easy enough.So i defined empty callbacks for testing purposes
funny thing: the
{ loading } = this.props
in the root component does get updated correctly but the{ this.props.children }
does not recognize any changes...so i had wo hack the system a bit and call it with an zero timeout and whoop - it works:
don't know it is an bug - or an feature :)
The text was updated successfully, but these errors were encountered: