Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed for latest markdown library #37

Merged
merged 1 commit into from Jul 24, 2022
Merged

Fixed for latest markdown library #37

merged 1 commit into from Jul 24, 2022

Conversation

Dzordzu
Copy link
Contributor

@Dzordzu Dzordzu commented Jul 15, 2022

No description provided.

@jordan-bucholtz
Copy link

Looks good to me, I had to make a similar fix locally. Hopefully this is merged soon.

@jcfr
Copy link

jcfr commented Jul 21, 2022

Thanks @Dzordzu for submitting the fix 🙏

@ryanfox When you have a chance, let us know if anything else is required to move forward with the integration.

@jcfr
Copy link

jcfr commented Jul 21, 2022

@ryanfox To provide some more context, here is improved commit message you could consider:

Fix documentation build due to breaking change in markdown

This commit workarounds backward incompatible change introduced in
Markdown 3.4 through Python-Markdown/markdown@659a43659 (Update th/td
to use style attribute)

It addresses error like the following:

  Extension error (sphinx_markdown_tables):
  Handler <function process_tables at 0x7f12fd69dc20> for event 'source-read' threw an exception (exception: __init__() missing 1 required positional argument: 'config')

See https://github.com/ryanfox/sphinx-markdown-tables/issues/36
and https://python-markdown.github.io/change_log/release-3.4/

@ryanfox
Copy link
Owner

ryanfox commented Jul 24, 2022

Thank you for the fix, everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants