Use deviceTypeVersion returned from API #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taik
force-pushed
the
thinh--fix-deviceTypeVersion
branch
from
c58d1fd
to
a0089e4
Compare
Taik
commented
Jun 30, 2023
| mid: this.#sessionID, | ||
| token: this.#accessToken, | ||
| application_version: "1.0.0", |
There was a problem hiding this comment.
The majority of these changes are me re-ordering the fields around to align to the same ordering of fields sent from the dashboard.
Taik
commented
Jun 30, 2023
| actionSource: 'WEB', | ||
| action: "actionControl", | ||
| macAddress: hvac.getMacAddress(), | ||
| deviceTypeVersion: hvac.getDeviceTypeVersion() || "BI01", |
Taik
commented
Jun 30, 2023
| @@ -86,12 +86,13 @@ class CieloAPIConnection { | |||
| device.deviceName, | |||
| device.applianceId, | |||
| device.fwVersion, | |||
| device.deviceTypeVersion | |||
There was a problem hiding this comment.
Recording the value gotten from the API to the local HVAC object.
Taik
changed the title
|
@Taik , thanks for picking this up! Work has been nuts for me recently, hence my radio-silence. These changes are what I was hoping for, it was tricky for me to test/discover of the the device specific differences since I only have one type of Cielo device at my house. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR records the
deviceTypeVersionvalue when populating device info object from the returned from the/web/devicesendpoint, and uses it when sending commands.I've tested this locally via
node demo.jsand all commands seems to be working. Apologies ahead of time for the big diff -- the majority of the changes are just fromprettierrunning.Some background context:
For newer Mr. Cool Split Units, the
deviceTypeVersionis different than what is originally hard-coded (BP01). For my device, BP04 is sent.Here's a sample
actionControlcommand payload:{ "action": "actionControl", "macAddress": "34945460CE2A", "deviceTypeVersion": "BI04", // <-- specifically this "fwVersion": "2.6.0,2.6.0", "actionSource": "WEB", "applianceType": "AC", "applianceId": 1663, "actionType": "temp", "actionValue": 80, "connection_source": 2, "token": "__REDACTED__", "actions": { "power": "on", "mode": "cool", "fanspeed": "auto", "temp": "80", "swing": "auto", "turbo": "off", "light": "off", "oldPower": "on" }, "mid": "chrome-1688162917", "application_version": "1.0.0", "ts": 1688164168 }