Skip to content
This repository has been archived by the owner on Mar 15, 2022. It is now read-only.

Update package.json #35

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Update package.json #35

merged 2 commits into from
Jun 15, 2020

Conversation

chapmanjacobd
Copy link
Contributor

when I run

$ parcel build --public-url ./ --no-cache src/pages/*.html
🚨 Build failed.
@parcel/core: Failed to resolve '@ryangjchandler/spruce' from './src/ts/mutable.ts'
@parcel/resolver-default: Could not load './dist/foo.module.js' from module '@ryangjchandler/spruce' found in package.json#module
/home/xk/pomelo/map-scratch-off/node_modules/@ryangjchandler/spruce/package.json:14:15
  13 |     "umd:main": "dist/spruce.umd.js",
> 14 |     "module": "dist/foo.module.js",
>    |               ^^^^^^^^^^^^^^^^^^^^ './dist/foo.module.js' does not exist, did you mean './dist/spruce.module.js'?'

it causes my build to fail

probably related to parcel-bundler/parcel#3500
I think it's not a good design choice for parcel v2 but it still is a bug/annoying

I'm not sure what all the implications are for removing this though

when I run 

```
$ parcel build --public-url ./ --no-cache src/pages/*.html
🚨 Build failed.
@parcel/core: Failed to resolve '@ryangjchandler/spruce' from './src/ts/mutable.ts'
@parcel/resolver-default: Could not load './dist/foo.module.js' from module '@ryangjchandler/spruce' found in package.json#module
/home/xk/pomelo/map-scratch-off/node_modules/@ryangjchandler/spruce/package.json:14:15
  13 |     "umd:main": "dist/spruce.umd.js",
> 14 |     "module": "dist/foo.module.js",
>    |               ^^^^^^^^^^^^^^^^^^^^ './dist/foo.module.js' does not exist, did you mean './dist/spruce.module.js'?'

```
it causes my build to fail

probably related to parcel-bundler/parcel#3500
I think it's not a good design choice for parcel v2 but it still is a bug/annoying

I'm not sure what all the implications are for removing this though
@ryangjchandler
Copy link
Owner

Hey @chapmanjacobd, thanks for opening this PR.

There is actually a .module.js file, would you mind putting the entry back and instead pointing it to /dist/spruce.module.js?

@chapmanjacobd
Copy link
Contributor Author

ok cool. updated

@ryangjchandler
Copy link
Owner

Thanks again @chapmanjacobd!

@ryangjchandler ryangjchandler merged commit e41b1a3 into ryangjchandler:master Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants