Merge pull request #19 from ryank109/calc-fix

Popup right position calculation fix
ryank109 · Jul 2, 2017 · bce6d9a · bce6d9a
2 parents 2b2d5da + b07a5d6
commit bce6d9a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,13 +1,14 @@
 {
   "name": "react-redux-popup",
-  "version": "2.1.0",
+  "version": "2.1.1",
   "description": "React redux popup",
   "main": "lib/react-redux-popup",
   "scripts": {
     "clean": "rimraf coverage lib test-reports",
     "build": "NODE_ENV=production webpack --config ./configs/webpack.config.js --progress --profile --colors",
     "coverage": "./node_modules/jest/bin/jest.js --coverage",
     "lint": "eslint src/**",
+    "prepublishOnly": "npm run clean && rm -rf node_modules && npm cache clean && npm i && npm run build",
     "start": "node ./example-app/server.js",
     "test": "./node_modules/jest/bin/jest.js",
     "test-dev": "./node_modules/jest/bin/jest.js --watch"

diff --git a/src/popup.jsx b/src/popup.jsx
@@ -52,11 +52,12 @@ export const HOCPopup = ComposedComponent => {
         }
 
         setPopupPosition() {
+            const popupRect = this.popup.getBoundingClientRect();
             const style = getPopupPosition(
                 this.props.anchor,
                 this.props.getRect(),
-                this.popup.clientWidth,
-                this.popup.clientHeight,
+                popupRect.width,
+                popupRect.height,
                 window.innerWidth,
                 window.innerHeight,
                 this.props.offset);