wip: Update to embedded-hal v1.0 #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hmm, this seems like the only way. At least I can't think of another. The trait has changed in a fundamentally breaking way, so we can only resort to interior mutability now. |
This was referenced Feb 19, 2024
|
Would be nice to get this :) |
|
Seconding! 😊 I'm trying to use a 0.2.x driver that's not likely to get 1.0 compat soon, and I would extremely love to not have to add that support right now. :D |
|
closing in favor of #34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how to handle
ReverseforInputPin: the 0.2 traits only give us&self, but the 1.0 traits require&mut self.Maybe we can not implement
InputPinonReverse<T>, and and add a second set of mpls onReverse<RefCell<T>>which does implInputPin??