-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-working to a general template for deploying PKI #8
Conversation
scripts/common.sh
Outdated
|
||
function generate_key { | ||
if [ ! -f "$1" ]; then | ||
openssl genrsa -out $1 2048 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should keysize be a var so it's easier to identify and change in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possibly, that and key type could be, but they’re also constrained by the yubikeys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can comment that constrainton the var though?
cc. @Firstyear @stoggi