Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle upcoming changes to Tweets #424

Open
philgyford opened this issue Jun 13, 2016 · 1 comment
Open

Handle upcoming changes to Tweets #424

philgyford opened this issue Jun 13, 2016 · 1 comment

Comments

@philgyford
Copy link
Contributor

philgyford commented Jun 13, 2016

There are some changes happening to Tweets at some point, as outlined in this post.

I can see a couple of things that need doing:

  • Add the new error code 386 ("The Tweet exceeds the number of allowed attachment types") to TWITTER_HTTP_STATUS_CODE in twython/endpoints.py
  • Make Twython.html_for_tweet() handle tweets that have no text field but do have a full_text field. Maybe just a quick check as to which field is present, and use that? I'm not sure if the method should do anything more clever.

I've read that post a couple of times now, and I don't think there's anything more Twython needs to do to cope, but I may well be wrong. A second opinion would be good! (fwiw, requesting tweets from the API with the new tweet_mode='extended' works, returning the new format of JSON.)

@ping
Copy link
Contributor

ping commented Sep 20, 2016

FYI, submitted PR #429 to add proper support in Twython.html_for_tweet() for extended tweets. Comments are welcomed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants