Added create_metadata endpoint #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpty and the status code is not 204. If params is not a dictionary, _transparent_params is not called
michaelhelmick
requested changes
Oct 9, 2017
twython/api.py
Outdated
| try: | ||
| if response.status_code == 204: | ||
| content = response.content | ||
| else: | ||
| content = response.json() | ||
| except ValueError: | ||
| raise TwythonError('Response was not valid JSON. \ | ||
| Unable to decode.') | ||
| if response.content!="": |
There was a problem hiding this comment.
Can you make this line:
if response.content != '' (spaces around operator and single quotes
twython/api.py
Outdated
| @@ -192,15 +196,16 @@ def _request(self, url, method='GET', params=None, api_call=None): | |||
| error_message, | |||
| error_code=response.status_code, | |||
| retry_after=response.headers.get('X-Rate-Limit-Reset')) | |||
|
|
|||
| content="" | |||
There was a problem hiding this comment.
content = '' Space around operators and single quotes
twython/api.py
Outdated
| @@ -140,7 +140,11 @@ def _request(self, url, method='GET', params=None, api_call=None): | |||
| params = params or {} | |||
|
|
|||
| func = getattr(self.client, method) | |||
| params, files = _transparent_params(params) | |||
| if type(params) is dict: | |||
There was a problem hiding this comment.
Can you make this if isinstance(params, dict)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the create_metadata endpoint for image descriptions. Now it should pass all tests. The following modifications have been made to api.py: