-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"3270" got renamed to "IBM 3270" from 2.2.2 to 2.3.0-RC #1012
Comments
The change cam with the update of 'Old' version names'New' version names |
Reason for their change has been this: which is a valid reason to change the name (I mentioned that oddity already somewhere else), but Ah, here is an old commented out substitution set: Hmm, I can not find the specs that does forbid start-digits, though. 🤔 |
static void BadFamily() {
ff_post_error(_("Bad Family Name"),_("Bad Family Name, must begin with an alphabetic character."));
} But how authoritative is that? |
I guess that is just a problem for web usage, not intrinsically for fonts themselves and desktop use: https://stackoverflow.com/questions/25752795/valid-font-family-names While digging deeper into the linked documents [1] seem to allow leading digits, they just must be escaped if one wants to use the family: [1] https://developer.mozilla.org/en-US/docs/Web/CSS/font-family#valid_family_names |
Naming comparisons right now
ALL have issues :-( |
[why] Somehow the `IBM 3270 SemiCondensed` font turn out as `IBM3270Semi Nerd Font Condensed`. The 3270 font always had the quirk to have a non-standard style with a dash. We have specific code to circumvent that. [how] After updating 3270 the 'Narrow' had been renamed to 'Condensed' and so our specific patch did not work anymore. Adapt the regex to find the new style that needs correction. [note] #1012 (comment) Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
[why] The font was always called 3270. Having a big company's name in the fontname is scary 😬 See rbanffy/3270font#60 [how] Add renaming rule. Fixes: ryanoasis#1012 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
🗹 Requirements
🎯 Subject of the issue
While working on the casks...
Experienced behavior:
Expected behavior:
No renaming, where does the
IBM
come from?🔧 Your Setup
Anonymice Powerline Nerd Font Complete.ttf
)?iterm2
,urxvt
,gnome
,konsole
)?★ Screenshots (Optional)
More info
The text was updated successfully, but these errors were encountered: