Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"3270" got renamed to "IBM 3270" from 2.2.2 to 2.3.0-RC #1012

Closed
3 tasks done
Finii opened this issue Nov 28, 2022 · 6 comments
Closed
3 tasks done

"3270" got renamed to "IBM 3270" from 2.2.2 to 2.3.0-RC #1012

Finii opened this issue Nov 28, 2022 · 6 comments
Milestone

Comments

@Finii
Copy link
Collaborator

Finii commented Nov 28, 2022

🗹 Requirements

  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have searched the FAQ for help
  • I have searched the Wiki for help

🎯 Subject of the issue

While working on the casks...

Experienced behavior:

diff --git a/Casks/font-3270-nerd-font.rb b/Casks/font-3270-nerd-font.rb
index 78681620..19edf1f9 100644
--- a/Casks/font-3270-nerd-font.rb
+++ b/Casks/font-3270-nerd-font.rb
@@ -1,15 +1,27 @@
 cask "font-3270-nerd-font" do
-  version "2.2.1"
-  sha256 "161ba437475fb162058c9947a7f62e214006ea7f8b4bda1fb2a9ea19077bf9af"
+  version "2.3.0-RC"
+  sha256 "69ddc77edf739d9b2699b5ccda288531a0f74a21fa92ea6a9e3c45bdb865634c"
 
   url "https://github.com/ryanoasis/nerd-fonts/releases/download/v#{version}/3270.zip"
   name "3270 Nerd Font (3270)"
+  desc "Developer targeted fonts with a high number of glyphs"
   homepage "https://github.com/ryanoasis/nerd-fonts"
 
-  font "3270-Medium Nerd Font Complete.otf"
-  font "3270 Narrow Nerd Font Complete.otf"
-  font "3270 Semi-Narrow Nerd Font Complete.otf"
-  font "3270-Medium Nerd Font Complete Mono.otf"
-  font "3270 Narrow Nerd Font Complete Mono.otf"
-  font "3270 Semi-Narrow Nerd Font Complete Mono.otf"
+  livecheck do
+    url :url
+    strategy :github_latest
+  end
+
+  font "IBM 3270 Condensed Nerd Font Complete Mono.otf"
+  font "IBM 3270 Condensed Nerd Font Complete Mono.ttf"
+  font "IBM 3270 Condensed Nerd Font Complete.otf"
+  font "IBM 3270 Condensed Nerd Font Complete.ttf"
+  font "IBM 3270 Nerd Font Complete Mono.otf"
+  font "IBM 3270 Nerd Font Complete Mono.ttf"
+  font "IBM 3270 Nerd Font Complete.otf"
+  font "IBM 3270 Nerd Font Complete.ttf"
+  font "IBM 3270 Semi-Condensed Nerd Font Complete Mono.otf"
+  font "IBM 3270 Semi-Condensed Nerd Font Complete Mono.ttf"
+  font "IBM 3270 Semi-Condensed Nerd Font Complete.otf"
+  font "IBM 3270 Semi-Condensed Nerd Font Complete.ttf"
 end

Expected behavior:

No renaming, where does the IBM come from?

🔧 Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
    • Please give the full filename
    • Where did you get the file from (download link, self patched, source downloaded from link...)
  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
  • Are you using OS X, Linux or Windows? And which specific version or distribution?

★ Screenshots (Optional)

More info

@Finii
Copy link
Collaborator Author

Finii commented Nov 28, 2022

The change cam with the update of 3270:

'Old' version names

image

image

'New' version names

image

image

@Finii
Copy link
Collaborator Author

Finii commented Nov 28, 2022

Reason for their change has been this:

which is a valid reason to change the name (I mentioned that oddity already somewhere else), but IBM is imho also problematic because it is a registered trademark or something (I bet).

Ah, here is an old commented out substitution set:

image

Hmm, I can not find the specs that does forbid start-digits, though. 🤔

@Finii
Copy link
Collaborator Author

Finii commented Nov 28, 2022

Hmm, I can not find the specs that does forbid start-digits, though.

fontforge/fontforgeexe/fontinfo.c

static void BadFamily() {                                                               
    ff_post_error(_("Bad Family Name"),_("Bad Family Name, must begin with an alphabetic character."));
}

But how authoritative is that?

@Finii
Copy link
Collaborator Author

Finii commented Nov 28, 2022

I guess that is just a problem for web usage, not intrinsically for fonts themselves and desktop use:

https://stackoverflow.com/questions/25752795/valid-font-family-names

While digging deeper into the linked documents [1] seem to allow leading digits, they just must be escaped if one wants to use the family:

image

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/font-family#valid_family_names

@Finii Finii changed the title 3270 got renamed from 2.2.2 to 2.3.0-RC "3270" got renamed to "IBM 3270" from 2.2.2 to 2.3.0-RC Nov 28, 2022
@Finii Finii added this to the v2.3.0 milestone Dec 28, 2022
@Finii
Copy link
Collaborator Author

Finii commented Jan 17, 2023

Naming comparisons right now

Nerd Fonts VERSION 2.2.2

 |Filename                                           | | Fullname                                                          | | Family                                                  | | Subfamily                      | | Typogr. Family                           | | Typogr. Subfamily
 |-------------------------------------------------- |-| ------------------------------------------------------------      |-| ------------------------------------------------------- |-| ------------------------------ |-| ---------------------------------------- |-| ----------------------------------------
 |3270-Medium Nerd Font Complete Mono.ttf            | | 3270-Medium Nerd Font Complete Mono                               | | 3270Medium Nerd Font Mono                               | | Medium                         | | 3270Medium Nerd Font Mono                | |
 |3270-Medium Nerd Font Complete Mono Windows Compat | | 3270-Medium Nerd Font Complete Mono Windows Compatible            | | 3270Medium NFM                                          | | Medium                         | | 3270Medium NFM                           | |
 |3270-Medium Nerd Font Complete.ttf                 | | 3270-Medium Nerd Font Complete                                    | | 3270Medium Nerd Font                                    | | Medium                         | | 3270Medium Nerd Font                     | |
 |3270-Medium Nerd Font Complete Windows Compatible. | | 3270-Medium Nerd Font Complete Windows Compatible                 | | 3270Medium NF                                           | | Medium                         | | 3270Medium NF                            | |
 |3270 Narrow Nerd Font Complete Mono.ttf            | | 3270 Narrow Nerd Font Complete Mono                               | | 3270Narrow Nerd Font Mono                               | | Medium                         | | 3270Narrow Nerd Font Mono                | |
 |3270 Narrow Nerd Font Complete Mono Windows Compat | | 3270 Narrow Nerd Font Complete Mono Windows Compatible            | | 3270Narrow NFM                                          | | Medium                         | | 3270Narrow NFM                           | |
 |3270 Narrow Nerd Font Complete.ttf                 | | 3270 Narrow Nerd Font Complete                                    | | 3270Narrow Nerd Font                                    | | Medium                         | | 3270Narrow Nerd Font                     | |
 |3270 Narrow Nerd Font Complete Windows Compatible. | | 3270 Narrow Nerd Font Complete Windows Compatible                 | | 3270Narrow NF                                           | | Medium                         | | 3270Narrow NF                            | |
 |3270 Semi-Narrow Nerd Font Complete Mono.ttf       | | 3270 Semi-Narrow Nerd Font Complete Mono                          | | 3270SemiNarrow Nerd Font Mono                           | | Medium                         | | 3270SemiNarrow Nerd Font Mono            | |
 |3270 Semi-Narrow Nerd Font Complete Mono Windows C | | 3270 Semi-Narrow Nerd Font Complete Mono Windows Compatible       | | 3270SemiNarrow NFM                                      | | Medium                         | | 3270SemiNarrow NFM                       | |
 |3270 Semi-Narrow Nerd Font Complete.ttf            | | 3270 Semi-Narrow Nerd Font Complete                               | | 3270SemiNarrow Nerd Font                                | | Medium                         | | 3270SemiNarrow Nerd Font                 | |
 |3270 Semi-Narrow Nerd Font Complete Windows Compat | | 3270 Semi-Narrow Nerd Font Complete Windows Compatible            | | 3270SemiNarrow NF                                       | | Medium                         | | 3270SemiNarrow NF                        | |

Nerd Fonts VERSION 2.3.0-RC2 (i.e. HEAD)

 |Filename                                           | | Fullname                                                          | | Family                                                  | | Subfamily                      | | Typogr. Family                           | | Typogr. Subfamily
 |-------------------------------------------------- |-| ------------------------------------------------------------      |-| ------------------------------------------------------- |-| ------------------------------ |-| ---------------------------------------- |-| ----------------------------------------
 |IBM 3270 Condensed Nerd Font Complete Mono.ttf     | | IBM 3270 Condensed Nerd Font Complete Mono                        | | 3270Condensed Nerd Font Mono                            | | Condensed                      | | 3270Condensed Nerd Font Mono             | |
 |IBM 3270 Condensed Nerd Font Complete Mono Windows | | IBM 3270 Condensed Nerd Font Complete Mono Windows Compatible     | | 3270Condensed NFM                                       | | Condensed                      | | 3270Condensed NFM                        | |
 |IBM 3270 Condensed Nerd Font Complete.ttf          | | IBM 3270 Condensed Nerd Font Complete                             | | 3270Condensed Nerd Font                                 | | Condensed                      | | 3270Condensed Nerd Font                  | |
 |IBM 3270 Condensed Nerd Font Complete Windows Comp | | IBM 3270 Condensed Nerd Font Complete Windows Compatible          | | 3270Condensed NF                                        | | Condensed                      | | 3270Condensed NF                         | |
 |IBM 3270 Nerd Font Complete Mono.ttf               | | IBM 3270 Nerd Font Complete Mono                                  | | 3270 Nerd Font Mono                                     | | Regular                        | | 3270 Nerd Font Mono                      | |
 |IBM 3270 Nerd Font Complete Mono Windows Compatibl | | IBM 3270 Nerd Font Complete Mono Windows Compatible               | | 3270 NFM                                                | | Regular                        | | 3270 NFM                                 | |
 |IBM 3270 Nerd Font Complete.ttf                    | | IBM 3270 Nerd Font Complete                                       | | 3270 Nerd Font                                          | | Regular                        | | 3270 Nerd Font                           | |
 |IBM 3270 Nerd Font Complete Windows Compatible.ttf | | IBM 3270 Nerd Font Complete Windows Compatible                    | | 3270 NF                                                 | | Regular                        | | 3270 NF                                  | |
 |IBM 3270 Semi-Condensed Nerd Font Complete Mono.tt | | IBM 3270 Semi-Condensed Nerd Font Complete Mono                   | | 3270SemiCondensed Nerd Font Mono                        | | Condensed                      | | 3270SemiCondensed Nerd Font Mono         | |
 |IBM 3270 Semi-Condensed Nerd Font Complete Mono Wi | | IBM 3270 Semi-Condensed Nerd Font Complete Mono Windows Compatibl | | 3270SemiCondensed NFM                                   | | Condensed                      | | 3270SemiCondensed NFM                    | |
 |IBM 3270 Semi-Condensed Nerd Font Complete.ttf     | | IBM 3270 Semi-Condensed Nerd Font Complete                        | | 3270SemiCondensed Nerd Font                             | | Condensed                      | | 3270SemiCondensed Nerd Font              | |
 |IBM 3270 Semi-Condensed Nerd Font Complete Windows | | IBM 3270 Semi-Condensed Nerd Font Complete Windows Compatible     | | 3270SemiCondensed NF                                    | | Condensed                      | | 3270SemiCondensed NF                     | |

Nerd Fonts VERSION 2.3.0-RC2 (i.e. HEAD) with --makegroups

 |Filename                                           | | Fullname                                                          | | Family                                                  | | Subfamily                      | | Typogr. Family                           | | Typogr. Subfamily
 |-------------------------------------------------- |-| ------------------------------------------------------------      |-| ------------------------------------------------------- |-| ------------------------------ |-| ---------------------------------------- |-| ----------------------------------------
 |IBM 3270 Nerd Font Complete Condensed.ttf          | | IBM 3270 Nerd Font Complete Condensed                             | | IBM3270 Nerd Font Condensed                             | | Regular                        | | IBM3270 Nerd Font                        | | Condensed
 |IBM 3270 Nerd Font Complete Mono Condensed.ttf     | | IBM 3270 Nerd Font Complete Mono Condensed                        | | IBM3270 Nerd Font Mono Condensed                        | | Regular                        | | IBM3270 Nerd Font Mono                   | | Condensed
 |IBM 3270 Nerd Font Complete Mono Windows Compatibl | | IBM 3270 Nerd Font Complete Mono Windows Compatible Condensed     | | IBM3270 NF Mono Condensed                               | | Regular                        | | IBM3270 NF Mono                          | | Condensed
 |IBM 3270 Nerd Font Complete Windows Compatible Con | | IBM 3270 Nerd Font Complete Windows Compatible Condensed          | | IBM3270 NF Condensed                                    | | Regular                        | | IBM3270 NF                               | | Condensed
 |IBM 3270 Nerd Font Complete Mono.ttf               | | IBM 3270 Nerd Font Complete Mono                                  | | IBM3270 Nerd Font Mono                                  | | Regular                        | |                                          | |
 |IBM 3270 Nerd Font Complete Mono Windows Compatibl | | IBM 3270 Nerd Font Complete Mono Windows Compatible               | | IBM3270 NF Mono                                         | | Regular                        | |                                          | |
 |IBM 3270 Nerd Font Complete.ttf                    | | IBM 3270 Nerd Font Complete                                       | | IBM3270 Nerd Font                                       | | Regular                        | |                                          | |
 |IBM 3270 Nerd Font Complete Windows Compatible.ttf | | IBM 3270 Nerd Font Complete Windows Compatible                    | | IBM3270 NF                                              | | Regular                        | |                                          | |
 |IBM3270 Semi Nerd Font Complete Condensed.ttf      | | IBM3270 Semi Nerd Font Complete Condensed                         | | IBM3270Semi Nerd Font Condensed                         | | Regular                        | | IBM3270Semi Nerd Font                    | | Condensed
 |IBM3270 Semi Nerd Font Complete Mono Condensed.ttf | | IBM3270 Semi Nerd Font Complete Mono Condensed                    | | IBM3270Semi Nerd Font Mono Condensed                    | | Regular                        | | IBM3270Semi Nerd Font Mono               | | Condensed
 |IBM3270 Semi Nerd Font Complete Mono Windows Compa | | IBM3270 Semi Nerd Font Complete Mono Windows Compatible Condensed | | IBM3270Semi NF Mono Condensed                           | | Regular                        | | IBM3270Semi NF Mono                      | | Condensed
 |IBM3270 Semi Nerd Font Complete Windows Compatible | | IBM3270 Semi Nerd Font Complete Windows Compatible Condensed      | | IBM3270Semi NF Condensed                                | | Regular                        | | IBM3270Semi NF    

ALL have issues :-(

Finii added a commit that referenced this issue Jan 17, 2023
[why]
Somehow the `IBM 3270 SemiCondensed` font turn out as
`IBM3270Semi Nerd Font Condensed`.

The 3270 font always had the quirk to have a non-standard style with a
dash. We have specific code to circumvent that.

[how]
After updating 3270 the 'Narrow' had been renamed to 'Condensed' and so
our specific patch did not work anymore.

Adapt the regex to find the new style that needs correction.

[note]
#1012 (comment)

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii closed this as completed in e5d8350 Jan 17, 2023
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 24, 2023
[why]
The font was always called 3270.
Having a big company's name in the fontname is scary 😬

See
rbanffy/3270font#60

[how]
Add renaming rule.

Fixes: ryanoasis#1012

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant