Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some update changed PROPO glyphs size #1588

Closed
3 tasks done
SolsticeSpectrum opened this issue Apr 4, 2024 · 3 comments · Fixed by #1596
Closed
3 tasks done

Some update changed PROPO glyphs size #1588

SolsticeSpectrum opened this issue Apr 4, 2024 · 3 comments · Fixed by #1596
Labels
confirmed not-a-bug not only wontfix but this is actually wanted

Comments

@SolsticeSpectrum
Copy link

SolsticeSpectrum commented Apr 4, 2024

🗹 Requirements

  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have searched the FAQ for help
  • I have searched the Wiki for help

🎯 Subject of the issue

Experienced behavior:
The propo glyphs were just fine couple of versions ago, I am not sure which version broke it because I haven't updated in like 3 months but
now the glyph sizes are just all over the place
some of them are just less bold than before

Also the leaf looked better before but that's just my opinion, the globe too

Expected behavior:
It should be same as it was before

Example symbols:
The problematic ones are: , , , , 󰖁, , , 

🔧 Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
    • Inconsolata Nerd Font Propo
  • Where did you get the file from (download link, self patched, source downloaded from link...)
  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
    • kitty
  • Are you using OS X, Linux or Windows? And which specific version or distribution?
    • Arch Linux

★ Screenshots (Optional)

Before:
image
image
image

After:
image
image
image

@Finii
Copy link
Collaborator

Finii commented Apr 5, 2024

Sorry to hear of your problems.

The icons listed as problematic are

F06C F1B6 F269 F011 F0581 F048 F051 F2C9
fa-leaf fa-steam fa-firefox fa-power_off md-volume_off fa-backward_step fa-forward_step fa-temperature_half
  • With the exception of 'volume off' all icons come from Font Awesome
  • When you use Nerd Font Propo the icon sizes are untouched by the patching
  • Any size differences come from upstream, i.e. from updating Font Awesome which has different sizes now

Lets have a look, leaf seems unchanged

image

image

Maybe firefox-browser is more what you like (a bit taller?)

image

Backward got just more squarish

image

Maybe use another taller set for 'backward', for example nf-md-skip_previous?

So updates in design always will look strange to some while others see the old icons as too-old-fashioned and out of place.

@Finii Finii changed the title Some update broke PROPO glyphs Some update changed PROPO glyphs size Apr 5, 2024
@Finii Finii added the confirmed label Apr 5, 2024
@Finii
Copy link
Collaborator

Finii commented Apr 5, 2024

I'm not sure yet, but I guess this is a not-a-bug unless I can be convinced it is.
Labeling but keeping open.

@Finii Finii added the not-a-bug not only wontfix but this is actually wanted label Apr 5, 2024
@Finii Finii mentioned this issue Apr 8, 2024
2 tasks
Finii added a commit that referenced this issue Apr 8, 2024
[why]
The glyphs can look a bit small(er) when used unscaled, for example in a
Nerd Font Propo font. Note that some icons indeed got smaller, but in
general the generated font is a bit smaller than before.

Related: #1588

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator

Finii commented Apr 8, 2024

Implemented a small (10%?) increase in size, but some icons are just smaller after the update, and we do not scale them generally (just as a whole).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed not-a-bug not only wontfix but this is actually wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants