Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase in FA icon size 3.2.0 to 3.2.1 #1614

Open
Finii opened this issue Apr 19, 2024 · 3 comments
Open

Increase in FA icon size 3.2.0 to 3.2.1 #1614

Finii opened this issue Apr 19, 2024 · 3 comments
Labels
confirmed ❲⚖❳glyph sizing not-a-bug not only wontfix but this is actually wanted

Comments

@Finii
Copy link
Collaborator

Finii commented Apr 19, 2024

Apologies if this is unrelated or intended, but I noticed an increase in the size of some symbols in ttf-firacode-nerd, going from 3.2.0 -> 3.2.1 in my i3 status bar.

3.2.0 3.2.1
2024-04-18_19-08 2024-04-18_19-09

U+F120 (nf-fa-terminal) and U+F11B (nf-fa-gamepad)

Originally posted by @martinpelikan in #1611 (comment)

@Finii
Copy link
Collaborator Author

Finii commented Apr 19, 2024

A lot glyphs changed size, but why? 😬 😆

image

@Finii
Copy link
Collaborator Author

Finii commented Apr 19, 2024

Ah here, it seems to be intended

1fe5837 FontAwesome: Scale glyphs a bit bigger

Which is part of

Lets compare the glyphs

You see, a lot glyphs got smaller on v3.1.1 -> v3.2.0 and grew back to a comparable size on v3.2.1.

For some other glyphs they stayed the same from v3.1.1 to v3.2.0 and now only grew with v3.2.1. But they usually also changed the outline (i.e. look different anyhow).

I don't know. The icons all changed with the substantial update from FA 4.7 (2016) to FA 6.5.1 (2024). The relative to each other sizes changed. It is hard to know what is now 'right'. In total the FA of our v3.2.0 was a bit on the small size (got reported) - not for all but for a lot icons. That was the reason to lift the size a bit.

Do you think the icons are now too big?
Sizewise I would look at v3.1.1 and v3.2.1, as v3.2.0 just lived 2 weeks or so.

image

@Finii Finii added ❲⚖❳glyph sizing confirmed not-a-bug not only wontfix but this is actually wanted labels Apr 19, 2024
@Finii Finii changed the title Increase in icon size 3.2.0 to 3.2.1 Increase in FA icon size 3.2.0 to 3.2.1 Apr 19, 2024
@martinpelikan
Copy link

Thank you for the very quick investigation and detailed response!

Do you think the icons are now too big?

From the perspective of my tiny use case, yes, but possibly because I grew used to the previous size. I'm not sure I would notice had they not overflowed the fixed size I had configured, something I can easily change.

I think I prefer the previous size because the line weight/thickness appears consistent with other symbols I use, but I haven't compared against many others. I wouldn't push for further changes if others are happy with where things are at.

Here's a comparison of the versions you mentioned:

3.1.1 3.2.1
2024-04-19_00-44 2024-04-19_00-45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed ❲⚖❳glyph sizing not-a-bug not only wontfix but this is actually wanted
Projects
None yet
Development

No branches or pull requests

2 participants