Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U+276F prompt character (❯) got smaller between 3.1.1 and 3.2.1 #1611

Closed
3 tasks done
gibfahn opened this issue Apr 17, 2024 · 11 comments Β· Fixed by #1617
Closed
3 tasks done

U+276F prompt character (❯) got smaller between 3.1.1 and 3.2.1 #1611

gibfahn opened this issue Apr 17, 2024 · 11 comments Β· Fixed by #1617

Comments

@gibfahn
Copy link
Contributor

gibfahn commented Apr 17, 2024

πŸ—Ή Requirements

  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have searched the FAQ for help
  • I have searched the Wiki for help

🎯 Subject of the issue

Experienced behavior:

Prompt character is now small.

Expected behavior:

Prompt character is large and easy to spot in the terminal.

Example symbols:

  • U+276F (❯)

πŸ”§ Your Setup

β˜… Screenshots

Screenshots taken at the same zoom in kitty.app on old and new font versions:

3.1.1 3.2.1
3.1.1 3.2.1
@Finii
Copy link
Collaborator

Finii commented Apr 17, 2024

Sorry to hear of your size problem.

I can see it directly in the font πŸ€”

image

Suspect

Because from these heavy brackets people DO expect excessively big icons πŸ€”

@Finii
Copy link
Collaborator

Finii commented Apr 17, 2024

In this example the icon is (far) less tall than the small letter T, which is strange

image

I will example in detail.

@Finii
Copy link
Collaborator

Finii commented Apr 17, 2024

The cell heights difference is quite huge here?

image

image

Not the case 'globally':

image

image

68% vs 76% ?

Hmm, thanks for reporting. This needs some consideration and a systematic check. I see the effect by the reason is not quite clear; and maybe that should have been marked with the ^ (fit to full height) modifier.

@Finii
Copy link
Collaborator

Finii commented Apr 17, 2024

Ahh, one should read ...

image

@Finii
Copy link
Collaborator

Finii commented Apr 17, 2024

Ah, the heavy brackets are now two times shrunken, there was an old rule that already sized them down relative to the full cell:

image

The rule needs to be changed to ^pa1! ....

@Finii
Copy link
Collaborator

Finii commented Apr 17, 2024

@allcontributors please add @gibfahn for bug

Copy link
Contributor

@Finii

I've put up a pull request to add @gibfahn! πŸŽ‰

@martinpelikan
Copy link

Apologies if this is unrelated or intended, but I noticed an increase in the size of some symbols in ttf-firacode-nerd, going from 3.2.0 -> 3.2.1 in my i3 status bar.

3.2.0 3.2.1
2024-04-18_19-08 2024-04-18_19-09

U+F120 (nf-fa-terminal) and U+F11B (nf-fa-gamepad)

@Finii
Copy link
Collaborator

Finii commented Apr 22, 2024

Where is the PR @Finii !!!?

gibfahn added a commit to gibfahn/nerd-fonts that referenced this issue Apr 22, 2024
Fixes: ryanoasis#1611

Co-Authored-By: Fini Jastrow <ulf.fini.jastrow@desy.de>
@gibfahn
Copy link
Contributor Author

gibfahn commented Apr 22, 2024

Thanks for the detailed explanation and the solution! I don't know if it's helpful, but I filed your proposed solution as a PR. I think that's right, don't have much experience in this area. #1617

It's your change, so if you want to file your own PR for it fine by me, just trying to reduce some cycles for you 😁 .

Finii added a commit that referenced this issue Apr 23, 2024
Fixes: #1611

Co-Authored-By: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator

Finii commented Apr 23, 2024

Most probably you already read it, but if not... the cryptic rules have some explanation

# Stretch 'xz' or 'pa' (preserve aspect ratio)
# Supported params: overlap | careful | xy-ratio | dont_copy | ypadding    
# Overlap value is used horizontally but vertically limited to 0.01
# Careful does not overwrite/modify existing glyphs
# The xy-ratio limits the x-scale for a given y-scale to make the ratio <= this value (to prevent over-wide glyphs)
# '1' means occupu 1 cell (default for 'xy')
# '2' means occupy 2 cells (default for 'pa')
# '!' means do the 'pa' scaling even with non mono fonts (else it just scales down, never up)
# '^' means that scaling shall fill the whole cell and not only the icon-cap-height (for mono fonts, other always use the whole cell)
# Dont_copy does not overwrite existing glyphs but rescales the preexisting ones
#
# Be careful, stretch may not change within a ScaleRule!
'align': 'c', 'valign': 'c', 'stretch': '^pa1!', 'params': {'ypadding': 0.3, 'careful': True}
  • Align horizontally and vertically in the center
  • Scale it with preserved aspect ratio (x and y scale is equal) into 1 cell (default would be 'up to 2' for pa)
  • Take the whole line-hight (^) and subtract 30% from the height (ypadding)
  • Do the scaling also for proportional fonts
  • Do not change preexisting glyphs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants