Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong codepoints for Font-Awesome beginning on f00f in table #31

Closed
dritter opened this issue Sep 15, 2015 · 12 comments
Closed

Wrong codepoints for Font-Awesome beginning on f00f in table #31

dritter opened this issue Sep 15, 2015 · 12 comments
Milestone

Comments

@dritter
Copy link

dritter commented Sep 15, 2015

Hi there!

When I use "Sauce Code Powerline Plus Nerd File Types Mono Plus Font Awesome Plus Octicons" the codepoints starting from f00f are off by one.
Example: The codepoint for home-icon on the table is f015. This should be the correct one, but if I do an echo "\uF015" it shows the wrong symbol. In the patched version the home-symbol has the codepoint F014. This is the case for all subsequent glyphs (seems to get worse with ongoing icons).

@ryanoasis
Copy link
Owner

Hey thanks for this info. I will look into it.

I was taking a break but now wanting to work on projects again here and there.

On this one I am reorganizing the patched folders to make fonts easier to find and then I want to merge in the 2 open PRs (hack font, fixes, and script refactoring)

@CestDiego
Copy link

@ryanoasis thank you for the awesome work. This fix would be greatly appreciated :)

@ryanoasis
Copy link
Owner

@CestDiego Thanks it is appreciated.


@dritter You are 100% correct


@dritter , @CestDiego
Ah I see what is going on here. I define the start and end range but quite a few of the glyphs in that range in font awesome are empty (e.g. f010 zoom_out [fa-search-minus]). So that point on its off by one and then each time another empty glyph is encountered its off-by-1++ 😊

I will get to this after a bit of re-organization of the folders and merging in the 2 PRs 😅

@ryanoasis ryanoasis added this to the v0.5.0 milestone Sep 18, 2015
@CestDiego
Copy link

@ryanoasis no problem...I'm developing a package similar to fontawesome.el for emacs in which one can easily add the unicode symbols with autocompletion backends :) looks like this:
alt

I am doing everything by hand because I have too much time in my hands..but I would appreciate it if there was some kind of json file that I could parse to get a name of the unicode symbol and it's hex numerical value for each of the glyphs included in the patched fonts :P

@ryanoasis
Copy link
Owner

@CestDiego Ah I see. That looks very cool and useful! I can see that being very helpful especially if you are using font awesome heavily in a project.

I would have made a plugin for emacs similar to my vim plugin (vim-devicons) but I am a Vim guy 😆 and I don't even know where to begin

If you need anything to make the font easier to use let me know (I see you already have one issue (#32) you opened 😅 )

@CestDiego
Copy link

@ryanoasis well yeah #32 is to make it easier to me to make Nix Expressions for NixOS packages :P but it would also be nice to download only the font one wants. Btw it's not really intuitive from file names which ones have which glyphs..have you considered having a webpage that let's users select which font they want with which variations? it would be so useful...I don't have the time now but in one month maybe I could help with that.

@ryanoasis
Copy link
Owner

@CestDiego I might ask you on #32 for more info on that subject. 😊

Yeah thats one problem right now with the directory structure. I was creating more subfolders for each family style but maybe I need subfolders for each glyphset variation because the names are very long

Website and interaction to let users pick is a very cool idea! I like it. 👍

The way I feel about this project right now is that there are a lot of little issues and a few big ones. I would love to get most of those ironed out and if this project starts to become more heavily used before creating a website. If/when those things happen then yeah definitely! 😄

@CestDiego
Copy link

awesome :) I look forward to the merging of the Hack Font PR :P btw, how to know if I'm downloading powerline-extras with the name of fonts? it looks like the font I downloaded doesn't have it. Also regarding Octicons seem to have the same shift as font awesome... and I think there is some overlapping :(

@ryanoasis
Copy link
Owner

@CestDiego 'powerline-extras' is currently missing 😞 (see #30)

Yeah it looks like it will have the same off-by-* issue as font-awesome. Fix should be the same.

For Octicons I decided to put it in a different range because font-awesome starts at the same unicode but I think what I should do is if you choose Octicons without font-awesome THEN it could start it its original place. Obviously at some point there is a limitation into which glyphs can be included and some needing to be moved when you want to include a bunch into one font 😟

@CestDiego
Copy link

So is Octicons kinda like >> fontawesome? it looks like github supports it natively...

@ryanoasis
Copy link
Owner

Yes similar in some ways. Yep it is the one used on GitHub 😄

FluxAugur pushed a commit to FluxAugur/nerd-fonts that referenced this issue May 25, 2016
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 24, 2023
…is#31)

* if conflict between Font Awesome and Octicons, Font Awesome takes presedence in positioning
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants