font-patcher: Fix line gap redistribution #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] Instead of redistributing the line gap we remove it. At least when HHEA or TYPO metrics are used. It's ok with WIN metrics. [how] If we have negative numbers for a gap and want to add more to it, where 'add' means 'make it more', we must of course _subtract_ the value. But baseline-to-baseline code into function so we can check it after all our gymnastics for correctness. It means the metrics. [note] Also correct out-of-sync comment. Fixes: #1116 Reported-by: Nathaniel Evan <nathanielevan> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
force-pushed
the
bugfix/linegap-again
branch
from
d49413a
to
0d5674a
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
Instead of redistributing the line gap we remove it. At least when HHEA or TYPO metrics are used.
It's ok with WIN metrics.
[how]
If we have negative numbers for a gap and want to add more to it, where 'add' means 'make it more', we must of course subtract the value.
But baseline-to-baseline code into function so we can check it after all our gymnastics for correctness. It means the metrics.
[note]
Also correct out-of-sync comment.
Fixes: #1116
Reported-by: Nathaniel Evan
Description
Please explain the changes you made here.
Requirements / Checklist
What does this Pull Request (PR) do?
Fix wrong gap removal on HHEA and TYPO metrics fonts. Was ok on WIN metrics fonts.
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)