Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FiraCode to v3.1 #473

Merged
merged 2 commits into from
Sep 6, 2020
Merged

Conversation

iamolivinius
Copy link
Contributor

Description

Please explain the changes you made here.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

This PR adds patched and unpatched FiraCode v.3.1 files to the repository

How should this be manually tested?

  1. Install Fira Code Regular Nerd Font Complete
  2. Configure your editor or terminal of choice to use FiraCode Nerd Font
  3. Enable ligatures if possible
  4. Check if you can see the adjusted combinations in your editor or terminal as they are shown here: https://github.com/tonsky/FiraCode#whats-in-the-box

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

adavidzh added a commit to adavidzh/nerd-fonts that referenced this pull request Apr 29, 2020
@adavidzh adavidzh mentioned this pull request Apr 29, 2020
5 tasks
@byg0n3
Copy link

byg0n3 commented May 19, 2020

as a follow up on this - FiraCode author released v4 yesterday with some noticeable changes
maybe consider switching to it instead of v3.1?

@felipecrs
Copy link

Actually, it's currently on v5.2.

@gitfool
Copy link
Contributor

gitfool commented Jun 28, 2020

FWIW, I wanted to learn more about how nerd fonts worked so I created PR #497 with the latest version.

@ryanoasis
Copy link
Owner

My bad this should've gotten merged in long ago. I'll probably work to get this in and then merge #497 so both will get counted

@ryanoasis ryanoasis merged commit 1aa8d4b into ryanoasis:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants