font-patcher: Set SFNT Version

[Finii]

Description

[why]
The Nerd Font Version is not added to the SFNT Version.
This is also a TODO item in font-patcher.
The SFNT-Revision is not updated at all.

[how]
Set the SFNT Version and Revision.

Requirements / Checklist

• Read the Contributing Guidelines
• Read or at least glanced at the FAQ
• Read or at least glanced at the Wiki
• Scripts execute without error (if necessary):
  • If any of the scripts were modified they have been tested and execute without error, e.g.:
    • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
    • ./gotta-patch-em-all-font-patcher\!.sh Hermit
• Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

Set the SFNT Version and let the SFNT Revision be recreated.

How should this be manually tested?

Any background context you can provide?

TODO item in font-patcher

What are the relevant tickets (if any)?

none

Screenshots (if appropriate or helpful)

Here the font is patched first with the origin/master version of font-patcher and afterwards with this MR applied:

Note the difference in Revision and the changed SFNT Version string.

query_version is one of several small fontforge helper scripts I use, maybe they should/could be added to bin/ somewhere. I am unsure if this is appropriate.

[Finii]

See MS SFNT table description Name ID code 5:

[Finii]

$ cat query_version

#!/usr/bin/env python
# coding=utf8

import fontforge
import sys

if len(sys.argv) != 2:
    print("Usage: {} font_name\n".format(sys.argv[0]))
    sys.exit(1)

font = fontforge.open(sys.argv[1])

l = []
for i, el in enumerate(font.sfnt_names):
    l += [(el[1], el[2])]
sfnt = dict(l)

print("Version is          '{}'".format(font.version));
print("CID Version is      '{}'".format(font.cidversion));
print("SFNT Revision is    '{}'".format(font.sfntRevision));
if "Version" in sfnt:
    print("SFNT ['Version'] is '{}'".format(sfnt["Version"]));
else:
    print("SFNT ['Version'] is not set".format(sys.argv[1]));

font.close()

[ryanoasis]

query_version is one of several small fontforge helper scripts I use, maybe they should/could be added to bin/ somewhere. I am unsure if this is appropriate.

Totally would be interested, especially in trying to build out more automated checks in github actions workflows.

[ryanoasis]

tested a ttf (see the fix) and otf (for sanity). works well.