font-parser: Allow patching without --ext #720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
Sometimes fontforge returns
None
forfont.path
. That should not be thecase according to specs:
This seems to be the case for fonts that do not have a
fullname
set.I did not search for nor file any issue at Fontforge.
[how]
In fact we already have the original font file name, and we want to
retain its extension anyhow (if nothing is specified), so we use the
filename that we opened to determine the extension.
[note]
Related: #412
Related: #641
[note]
This was the sole usage of font.path.
Has been introduced with commit d8b760a which looks uncritical.
Requirements / Checklist
./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
./gotta-patch-em-all-font-patcher\!.sh Hermit
What does this Pull Request (PR) do?
Use the specified filename directly to detect the filename instead of the round trip through Fontforge that somehow sometimes fails.
How should this be manually tested?
Patch for example
SourceHanCodeJP-Regular.otf
orNoto Sans CJK Bold.otf
Any background context you can provide?
What are the relevant tickets (if any)?
#412 #641
Screenshots (if appropriate or helpful)
Edit: Typo