Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List AUR packages for Jetbrains & Victor Mono #887

Merged
merged 2 commits into from
Aug 23, 2022
Merged

List AUR packages for Jetbrains & Victor Mono #887

merged 2 commits into from
Aug 23, 2022

Conversation

avalonv
Copy link
Contributor

@avalonv avalonv commented Aug 21, 2022

Description

Added two fonts to the AUR section of the README

These are currently the 3rd and 4th most popular Nerd Fonts packages in the AUR respectively, and I felt they should be included.

Requirements / Checklist

What does this Pull Request (PR) do?

See description.

Screenshots (if appropriate or helpful)

image

These are currently the 3rd and 4th most popular Nerd Fonts packages on the AUR respectively, and I felt they should be included
@Finii
Copy link
Collaborator

Finii commented Aug 22, 2022

Excellent, thank you!

Wouldn't it make sense to list the packages in popularity or at least alphabetical order? *ponder*

@avalonv
Copy link
Contributor Author

avalonv commented Aug 22, 2022

Up to you really, I could reorder them if you'd like.

I think alphabetical order makes more sense since popularity fluctuates with time.

@avalonv
Copy link
Contributor Author

avalonv commented Aug 23, 2022

@Finii would you like me to do that and open a new PR?

And include a link to the AUR package search, because we do not list all
packages but only some.

Make nerd-fonts-git more prominant and list together with the other
'all' packages.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator

Finii commented Aug 23, 2022

Well, I just added a commit with the reordering.

And I learned about nerd-fonts-git which is nice.

Thanks again for the PR and that you care :-)

@Finii Finii merged commit ccc6f4e into ryanoasis:master Aug 23, 2022
@Finii
Copy link
Collaborator

Finii commented Aug 23, 2022

Hmm, somehow your commit vanished?!?
I hate merge commits, but somehow github said it was needed and no FF could be performed (on the command line it was no problem, though)

image

Sorry :-(

@Finii
Copy link
Collaborator

Finii commented Aug 23, 2022

Hmm, you commit IS in the repo, but just not shown by the github web frontend?

This is the repo on current master in tig
image

@Finii
Copy link
Collaborator

Finii commented Aug 23, 2022

Oh, github lists the commits chronologically and not in the order they are applied....

image

I miss gitlab's 'graph' view of commits. Is there an equivalent on github?

LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
List AUR packages for Jetbrains & Victor Mono
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants