Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with 0.6.0 Update #109

Closed
mhartington opened this issue Aug 28, 2015 · 13 comments
Closed

Error with 0.6.0 Update #109

mhartington opened this issue Aug 28, 2015 · 13 comments
Assignees

Comments

@mhartington
Copy link
Collaborator

Not sure whats up, but got this error when I updated.

Error detected while processing /Users/mhartington/.nvim/bundle/vim-devicons/nerdtree_plugin/webdevicons.vim:
line  118:
E121: Undefined variable: g:DevIconsEnableFoldersOpenClose
E15: Invalid expression: g:DevIconsEnableFoldersOpenClose
Error detected while processing /Users/mhartington/.nvim/bundle/vim-devicons/plugin/webdevicons.vim:
line  114:
E121: Undefined variable: g:DevIconsEnableFoldersOpenClose
E15: Invalid expression: g:DevIconsEnableFoldersOpenClose
Press ENTER or type command to continue
@ryanoasis
Copy link
Owner

eeek ouch. Thanks. I think I see the issue

@ryanoasis
Copy link
Owner

@mhartington Can you see if it works for you now?

@mhartington
Copy link
Collaborator Author

Hmm, still getting something

Error detected while processing /Users/mhartington/.nvim/bundle/vim-devicons/nerdtree_plugin/webdevicons.vim:
line  118:
E121: Undefined variable: g:DevIconsEnableFoldersOpenClose
E15: Invalid expression: g:DevIconsEnableFoldersOpenClose
Press ENTER or type command to continue

@ryanoasis
Copy link
Owner

crap yep

ryanoasis added a commit that referenced this issue Aug 28, 2015
)

* need to also define inside nerdtree plugin file (duplicate variables for now)
@ryanoasis
Copy link
Owner

I have it fixed on my end. How about you?

@mhartington
Copy link
Collaborator Author

That one seems to have done it 👍
Thanks!

@ryanoasis
Copy link
Owner

Awesome 🎉 😰

No thank you! I was lucky to get your report soon after pushing!

Probably time to think about adding some basic build tests. I did not catch the error because of my vimrc settings.

@mhartington
Copy link
Collaborator Author

@ryanoasis
Copy link
Owner

Yeah something like that. I have seen that one and a few nice other ones.

BTW for 'ts' icons you'll need a latest font from https://github.com/ryanoasis/nerd-fonts 😄

@mhartington
Copy link
Collaborator Author

Already downloaded 😁
Holy Icons! Thats a big update to SourceCode Pro.
Thanks a lot

@ryanoasis
Copy link
Owner

😉 Yeah, however there are still some basic problems with the patched fonts (most of the open tickets are related to the fonts).

I am probably going to simply the directory structure and make it easier to download the font that has everything.. because right now its very hard to see and know which one you want IMHO

@mhartington
Copy link
Collaborator Author

Happy to help out how ever I can.

@ryanoasis
Copy link
Owner

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants