Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): fix character encoding #178

Merged
merged 1 commit into from
Oct 21, 2016
Merged

Conversation

mhartington
Copy link
Collaborator

Requirements (please check off with 'x')

What does this Pull Request (PR) do?

Resolve character encoding issues that prevent doc tags from being generated.
Replaces dash with a hyphen -.

Any background context you can provide?

#162

@ryanoasis
Copy link
Owner

Thanks for this. I will merge it in soon.

I just realized this fix looks familiar and now I know why: sergei-dyshel@85b084b

Looks like a PR was never sent from that fork.

@sergei-dyshel please submit a PR if you want proper contribution credit.

Either way I will mention both of you in the next release notes regarding the fix.

😄

@ryanoasis ryanoasis added this to the v0.9.0 milestone Oct 20, 2016
@ryanoasis ryanoasis merged commit 4aff83f into ryanoasis:master Oct 21, 2016
@sergei-dyshel
Copy link

@ryanoasis Actually I didn't intend to submit the PR since I got impression that you're waiting for @Shougo to fix plugin manager instead. Thanks for taking initiative 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants