Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add icon for solidity with file extension .sol (using ether icon) #396

Closed
wants to merge 3 commits into from

Conversation

Adoliin
Copy link

@Adoliin Adoliin commented Jul 7, 2021

Requirements (please check off with 'x')

What does this Pull Request (PR) do?

This PR is to resolve #395

How should this be manually tested?

Any background context you can provide?

I noticed that there is no icons on Solidity files , so I searched for one in nerd fonts icons and chose the Ether icon since Solidity is the language for developing smart contracts on the Ethereum Virtual Machine

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

sol-vim

@get-me-power
Copy link
Collaborator

@Adoliin
Thanks.
Could you also add test?

@Adoliin
Copy link
Author

Adoliin commented Jul 16, 2021

@kazukazuinaina
Yes, sure!

@get-me-power
Copy link
Collaborator

@Adoliin
Thanks, Also, Could you sqhash merge commit?
I think this commit is dirty.

@Adoliin
Copy link
Author

Adoliin commented Jul 23, 2021

@Adoliin
Thanks, Also, Could you sqhash merge commit?
I think this commit is dirty.

Sorry I did not get what you meant.
What commits should I squash?

@get-me-power
Copy link
Collaborator

get-me-power commented Jul 27, 2021

@Adoliin

Don't worry, I've squash the commit and imported your commit into master.
Thanks for your contribution!

reference

aa13718
7979aac

@Adoliin
Copy link
Author

Adoliin commented Jul 28, 2021

Nice :)
Your welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add solidity language (.sol file extension) icon instead of showing generic icon
2 participants