Allow custom distro icon #446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new configuration option to allow one to specify they own distro icon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements (please check off with 'x')
What does this Pull Request (PR) do?
Adds a configuration variable,
g:WebDevIconsDistroto allow users to specify their distribution's icon. Several popular distributions are not supported "out of the box" by this plugin, i.e., Fedora, Suse Linux, etc. This PR also adds my particular distro: Manjaro Linux.How should this be manually tested?
I use vim-plug as my vim plugin manager. I have vim-devicons plugin listed last, as directed.
I use
let g:WebDevIconsDistro = "\uF30B"in my.vimrcto force vim-devicons to use my selected icon. This produced the following result:Next, I removed the custom distro icon setting from my
.vimrcto test that the addition of Manjaro as a detected Linux distribution is working. This resulted in:Any background context you can provide?
N/A
What are the relevant tickets (if any)?
Fixes #445
Screenshots (if appropriate or helpful)
N/A