Merge pull request #18 from hugojosefson/whitespace

Fix multi-line text paragraphs
ryansolid · Jul 18, 2020 · 4979f5f · 4979f5f
2 parents af0626a + 3529163
commit 4979f5f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/packages/babel-plugin-jsx-dom-expressions/src/shared/utils.js b/packages/babel-plugin-jsx-dom-expressions/src/shared/utils.js
@@ -126,7 +126,7 @@ export function trimWhitespace(text) {
       .split("\n")
       .map((t, i) => (i ? t.replace(/^\s*/g, "") : t))
       .filter(s => !/^\s*$/.test(s))
-      .join("");
+      .join(" ");
   }
   return text.replace(/\s+/g, " ");
 }

diff --git a/packages/babel-plugin-jsx-dom-expressions/test/__dom_fixtures__/textInterpolation/code.js b/packages/babel-plugin-jsx-dom-expressions/test/__dom_fixtures__/textInterpolation/code.js
@@ -29,6 +29,12 @@ const multiLineTrailingSpace = <span>
   John
 </span>
 
+/* prettier-ignore */
+const multiLineNoTrailingSpace = <span>
+  Hello
+  John
+</span>
+
 /* prettier-ignore */
 const escape = <span>
   &nbsp;&lt;Hi&gt;&nbsp;

diff --git a/packages/babel-plugin-jsx-dom-expressions/test/__dom_fixtures__/textInterpolation/output.js b/packages/babel-plugin-jsx-dom-expressions/test/__dom_fixtures__/textInterpolation/output.js
@@ -84,4 +84,7 @@ const multiLine = _tmpl$7.cloneNode(true);
 const multiLineTrailingSpace = _tmpl$3.cloneNode(true);
 /* prettier-ignore */
 
+const multiLineNoTrailingSpace = _tmpl$3.cloneNode(true);
+/* prettier-ignore */
+
 const escape = _tmpl$8.cloneNode(true);