Automated updates for buildGoModule packages #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having merged an update to make go packages passthru the `modSha256` [1], we can now have `nixpkgs-update` inspect it and make updates, just as it now does for Rust packages as of [2]. As a slight detail, because the attribute is in `passthru` rather than actually being available in the derivation, we just do the equivalent of `nix eval -f . <attrPath>.<attr>` rather than going through the `drvAttrs` as before. This version has been tested successfully with at least one go update [3], but not thoroughly vetted. That said, it's essentially identical to the Rust implementation that has been working well for some time now. [1] NixOS/nixpkgs#82027 [2] nix-community#156 [3] NixOS/nixpkgs#82465
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having merged an update to make go packages passthru the
modSha256[1], we cannow have
nixpkgs-updateinspect it and make updates, just as it now does forRust packages as of [2].
As a slight detail, because the attribute is in
passthrurather than actuallybeing available in the derivation, we just do the equivalent of
nix eval -f . <attrPath>.<attr>rather than going through thedrvAttrsas before.This version has been tested successfully with at least one go update [3], but
not thoroughly vetted. That said, it's essentially identical to the Rust
implementation that has been working well for some time now.
[1] NixOS/nixpkgs#82027
[2] #156
[3] NixOS/nixpkgs#82465