Skip to content

Commit

Permalink
runtime: controlport: Use headers with rpcserver class definitions.
Browse files Browse the repository at this point in the history
Instead of just declaring the rpcserver_base and rpcserver_thrift
classes, just include the headers that actually define them. With only
declarations, MSVC fails to build rpcserver_selector.cc because it
cannot verify that rpcserver_thrift inherits from rpcserver_base.

Signed-off-by: Ryan Volz <ryan.volz@gmail.com>
  • Loading branch information
ryanvolz committed Sep 19, 2023
1 parent f490e1a commit 9825804
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions gnuradio-runtime/include/gnuradio/rpcserver_booter_base.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,10 @@
#ifndef RPCSERVER_BOOTER_BASE
#define RPCSERVER_BOOTER_BASE

#include <gnuradio/rpcserver_base.h>
#include <string>
#include <vector>

class rpcserver_base;

class rpcserver_booter_base
{
public:
Expand Down
3 changes: 1 addition & 2 deletions gnuradio-runtime/include/gnuradio/rpcserver_booter_thrift.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,9 @@

#include "thrift/ControlPort.h"
#include <gnuradio/rpcserver_booter_base.h>
#include <gnuradio/rpcserver_thrift.h>
#include <gnuradio/thrift_server_template.h>

class rpcserver_base;
class rpcserver_thrift;

class rpcserver_booter_thrift
: public virtual rpcserver_booter_base,
Expand Down

0 comments on commit 9825804

Please sign in to comment.