Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dplyr and jsonlite as dependencies #8

Closed
ryapric opened this issue Mar 15, 2020 · 3 comments
Closed

Remove dplyr and jsonlite as dependencies #8

ryapric opened this issue Mar 15, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ryapric
Copy link
Owner

ryapric commented Mar 15, 2020

I've grown to be wary of external dependencies, both in terms of potential breakage but also in terms of install time/size. A user who just wants to log their script/package entries shouldn't need to spend 20 minutes compiling C/C++ packages (on a Linux deployment host) just to enable that feature. loggit is currently using dplyr only for its bind_rows() functionality, which is easy to replicate in base R. It's leaning heavily into jsonlite though, and that will take some fudging on the read-in-the-data side of things. But writes should be easy to roll my own.

@ryapric ryapric added the enhancement New feature or request label Mar 15, 2020
@ryapric ryapric added this to the v2 milestone Mar 15, 2020
@ryapric ryapric self-assigned this Mar 15, 2020
@ryapric
Copy link
Owner Author

ryapric commented Mar 15, 2020

dplyr is removed, replaced with the internal function bind_rows_loggit(), which appends two data frames regardless of column names/ordering. For more than two at a time, just be sure to run it in a Reduce() call.

@ryapric
Copy link
Owner Author

ryapric commented Mar 15, 2020

Note: I am aware of the compilation-time improvements in dplyr 1.0.0 (which is AWESOME!), but my point above still stands.

@ryapric
Copy link
Owner Author

ryapric commented Mar 29, 2020

jsonlite is now removed from Imports as well, replaced by read_ndjson() and write_ndjson() and friends.

@ryapric ryapric closed this as completed Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant