Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpv: add module #696

Closed
wants to merge 1 commit into from
Closed

mpv: add module #696

wants to merge 1 commit into from

Conversation

tadeokondrak
Copy link
Member

No description provided.

rycee
rycee requested changes May 2, 2019
View reviewed changes
Copy link
Member

@rycee rycee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks really nice 🙂

I added a few comments, though. Once fixed I think it should be fine for merge.

modules/programs/mpv.nix Outdated Show resolved Hide resolved
modules/programs/mpv.nix Outdated Show resolved Hide resolved
modules/programs/mpv.nix Outdated Show resolved Hide resolved
modules/programs/mpv.nix Outdated Show resolved Hide resolved
modules/programs/mpv.nix Outdated Show resolved Hide resolved
modules/programs/mpv.nix Outdated Show resolved Hide resolved
rycee
rycee reviewed May 4, 2019
View reviewed changes
modules/programs/mpv.nix Outdated Show resolved Hide resolved
@rycee
Copy link
Member

rycee commented May 7, 2019

Thanks! Works well for me 🙂

Rebased to master in 8b15f18.

@rycee rycee closed this May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee rycee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tadeokondrak @rycee