Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct detect template dir for core.hooksPath install modes #134

Merged

Conversation

gabyx
Copy link
Contributor

@gabyx gabyx commented Oct 8, 2020

No description provided.

- in the update case, we need to include a set `githooks.useCoreHooksPath` and warn and fail if we did not find a template directory after checking the default locations.
@gabyx
Copy link
Contributor Author

gabyx commented Oct 8, 2020

Here the test again. The merge was a bit too fast :-) Sorry. The test 114 fails without the fix

@gabyx gabyx changed the title Bugfix/install and update corehookspath Correct detect template dir for core.hooksPath install modes Oct 8, 2020
@gabyx
Copy link
Contributor Author

gabyx commented Oct 8, 2020

Thx for merging.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 829

  • 12 of 19 (63.16%) changed or added relevant lines in 1 file are covered.
  • 91 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 80.591%

Changes Missing Coverage Covered Lines Changed/Added Lines %
install.sh 12 19 63.16%
Files with Coverage Reduction New Missed Lines %
install.sh 91 68.33%
Totals Coverage Status
Change from base Build 828: 0.03%
Covered Lines: 2371
Relevant Lines: 2942

💛 - Coveralls

@rycus86
Copy link
Owner

rycus86 commented Oct 8, 2020

Here the test again. The merge was a bit too fast :-) Sorry. The test 114 fails without the fix

Hm, odd, I checked Travis and looked fine.

@rycus86 rycus86 merged commit 1cb6bf0 into rycus86:master Oct 8, 2020
@gabyx
Copy link
Contributor Author

gabyx commented Oct 8, 2020

Sorry: The test was not in the last PR you merged :-)

@gabyx gabyx deleted the bugfix/install-and-update-corehookspath branch October 8, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants