Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppBar color issue when using seed generated scheme with key color locked #198

Open
rydmike opened this issue Oct 13, 2023 · 0 comments
Open
Assignees
Labels
bug Something isn't working package Report concerns the FlexColorScheme core package V8 This issue concerns version 8 and will be addressed in it
Milestone

Comments

@rydmike
Copy link
Owner

rydmike commented Oct 13, 2023

Setting AppBar color to e.g. primary color in a seed generated ColorScheme and locking e.g. primary color to seed color, results in none-locked seed generated primary color as AppBar color, instead of the expected used locked primary seed color.

For example this:

theme: FlexThemeData.light(
  scheme: FlexScheme.rosewood,
  subThemesData: const FlexSubThemesData(
    appBarBackgroundSchemeColor: SchemeColor.primary,
  ),
  keyColors: const FlexKeyColors(
    keepPrimary: true,
  ),
  useMaterial3: true,  
),

Will result in AppBar color 0xFFA5393D and not 0xFF5C000E as expected.

Screenshot 2023-10-13 at 22 19 34

@rydmike rydmike self-assigned this Oct 13, 2023
@rydmike rydmike added this to the 7.4.0 milestone Oct 13, 2023
@rydmike rydmike changed the title AppBar primary color issue when using seed generated scheme with key locked primary color AppBar color issue when using seed generated scheme with key color locked Oct 13, 2023
@rydmike rydmike added the bug Something isn't working label Oct 14, 2023
rydmike added a commit that referenced this issue Oct 14, 2023
These tests fails due to reported issue, but should pass when the issue has been fixed.
rydmike added a commit that referenced this issue Oct 14, 2023
@rydmike rydmike added package Report concerns the FlexColorScheme core package V7 This issue concerns version 7 and will be addressed in it labels Oct 24, 2023
@rydmike rydmike added V8 This issue concerns version 8 and will be addressed in it and removed V7 This issue concerns version 7 and will be addressed in it labels Apr 26, 2024
@rydmike rydmike modified the milestones: 7.4.0, 8.0.0 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package Report concerns the FlexColorScheme core package V8 This issue concerns version 8 and will be addressed in it
Projects
Status: Done
Development

No branches or pull requests

1 participant