Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements 🚀 #92

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

rygelouv
Copy link
Owner

@rygelouv rygelouv commented Dec 27, 2023


🚀 Description

  • Debugging Improvements
    The changes make the 'debug' version of the software easier to inspect for developers. Now, detailed review of performance (coverage) is available during testing. This will help our team identify any issues faster and more efficiently.

  • App Identification and Profiling
    A unique identifier has been added to our software, enabling it to be recognized amongst other applications. Profiling tags were also included, which will assist in observing the app's behavior.

  • Strict Mode Adjustment
    The software now includes 'Strict Mode', a diagnostic tool used to catch common mistakes and issues, such as memory leaks and non-optimal operations. This mode is only active during the development stage and will make the process more efficient.

  • URL Generator Modifications
    There were modifications to the URL generator part of our software. These changes optimize how online data is fetched, thereby improving the app speed and responsiveness.

  • Sign-in Changes
    Changes have been made related to user sign-in. This switch will allow users to sign in anonymously if they want to. Furthermore, the software will provide a more helpful error message if any problems occur with the anonymous sign-in process.

  • Onboarding Changes
    Adjustments have been made to the onboarding process, specifically to the behavior of the 'next' button. This will provide a more intuitive and user-friendly experience for new users.

  • New Files Addition
    There have been a number of new files added, which pertain to performance benchmarking of the app. This will allow us to objectively measure and improve the performance of our application.

  • Plugin Application
    A plugin has been applied to the project. Plugins enhance the functionality of the build script. This particular plugin will aid Android compatibility.

  • Benchmark Subproject
    Finally, a new subproject named 'benchmark' was included in the project. This new addition will help us to measure the specific performance markers of the app, which are important for optimization.

Issue (if applicable):
Issue: #91

🖼 Screenshots/Videos (if applicable)

  • Before:
    [Attach before screenshot or link to video]

  • After:
    [Attach after screenshot or link to video]

📦 Dependencies

  • Added new dependencies? List:
  • Updated existing?

🧪 Testing

Describe the steps to reproduce:

📱 Checklist

  • Tested on all supported devices and OS versions
  • UI/UX conforms to project design guidelines
  • Unit/integration tests added
  • Relevant documentation updated (e.g., README, Wiki, etc.)
  • Checked linter on local.

…horizedAccounts to false and added more configuration for release built type
… a background thread, updated firebase BOM to fix FirebaseAuth R8 issues
@rygelouv rygelouv added project setup chore When something related to the project is done refactor when doing some refactoring task Performances Everything related to performance improvments labels Dec 27, 2023
@rygelouv rygelouv added this to the 0.5.0 milestone Dec 27, 2023
@rygelouv rygelouv self-assigned this Dec 27, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR automatically approved by auto-approve-action

Copy link

sonarcloud bot commented Dec 27, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (9a50764) 30.77% compared to head (a22be62) 31.01%.

Files Patch % Lines
...books/tanga/feature/onboarding/OnboardingScreen.kt 0.00% 8 Missing ⚠️
...pp/books/tanga/common/urls/DownloadUrlGenerator.kt 77.77% 0 Missing and 2 partials ⚠️
...main/java/app/books/tanga/di/GoogleSignInModule.kt 0.00% 2 Missing ⚠️
app/src/main/java/app/books/tanga/TangaApp.kt 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev      #92      +/-   ##
============================================
+ Coverage     30.77%   31.01%   +0.23%     
- Complexity       50       51       +1     
============================================
  Files           142      142              
  Lines          5124     5149      +25     
  Branches        856      857       +1     
============================================
+ Hits           1577     1597      +20     
- Misses         3238     3242       +4     
- Partials        309      310       +1     
Flag Coverage Δ
uitests 20.96% <60.00%> (+0.27%) ⬆️
unittests 15.00% <24.32%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performances Everything related to performance improvments project setup chore When something related to the project is done refactor when doing some refactoring task
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

1 participant