Make installing shellcheck more robust
#79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftp.debian.org only keeps the latest build of any release.
Don't spoil the caller namespace, however small the changes are
| else | ||
| time $SHELL bin/shpec shpec/shpec_shpec.sh | ||
| fi | ||
| - | |
There was a problem hiding this comment.
@hlangeveld - yer | seems safer. 👍
Restores `if ... then ... else ... ` and reverts to `elif ...` in the LINT or SHELL shpec run. This reverts commit aac5ee0, but keeps the sh -> POSIX comment. Cosmetic: remove trailing whitespace
|
Looks good to me! |
rylnd
added a commit
that referenced
this pull request
May 6, 2015
Make installing `shellcheck` more robust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core functional change here is that we allow travis to fallback on a known, existing version in the debian
shellcheckrepository.So now we work with a list of known versions of shellcheck, and a function
get_shellcheckthatwill download the first valid match and report the proper package name.
If no valid package can be downloaded, package name will be empty, and the install will abort.
Cosmetic changes:
>to Literal|for multi-line shell chunks. I would expect folding to generate shell syntax errors, but I haven't seen any. Does travis interpret this yaml correctly?-s sh. It's the POSIX way.