Skip to content

Commit

Permalink
use links to static files rather than direct inclusion, Fixes jazzban…
Browse files Browse the repository at this point in the history
  • Loading branch information
graingert committed Aug 20, 2012
1 parent 359ddb4 commit 20e9253
Show file tree
Hide file tree
Showing 25 changed files with 7 additions and 16 deletions.
4 changes: 2 additions & 2 deletions debug_toolbar/templates/debug_toolbar/base.html
@@ -1,9 +1,9 @@
{% load i18n %}
<style type="text/css">
@media print { #djDebug {display:none;}}
{{ css }}
</style>
<script type="text/javascript">{{ js }}</script>
<link rel="stylesheet" href="{{ STATIC_URL }}debug_toolbar/css/toolbar.min.css" type="text/css">
<script type="text/javascript" src="{{ STATIC_URL }}debug_toolbar/css/toolbar.min.js"></script>
<div id="djDebug" style="display:none;" dir="ltr">
<div style="display:none;" id="djDebugToolbar">
<ul id="djDebugPanelList">
Expand Down
2 changes: 0 additions & 2 deletions debug_toolbar/toolbar/loader.py
Expand Up @@ -60,8 +60,6 @@ def render_toolbar(self):
context = self.template_context.copy()
context.update({
'panels': self.panels,
'js': mark_safe(open(os.path.join(media_path, 'js', 'toolbar.min.js'), 'r').read()),
'css': mark_safe(open(os.path.join(media_path, 'css', 'toolbar.min.css'), 'r').read()),
})

return render_to_string('debug_toolbar/base.html', context)
Expand Down
1 change: 0 additions & 1 deletion debug_toolbar/urls.py
Expand Up @@ -9,7 +9,6 @@
_PREFIX = '__debug__'

urlpatterns = patterns('',
url(r'^%s/m/(.*)$' % _PREFIX, 'debug_toolbar.views.debug_media'),
url(r'^%s/sql_select/$' % _PREFIX, 'debug_toolbar.views.sql_select', name='sql_select'),
url(r'^%s/sql_explain/$' % _PREFIX, 'debug_toolbar.views.sql_explain', name='sql_explain'),
url(r'^%s/sql_profile/$' % _PREFIX, 'debug_toolbar.views.sql_profile', name='sql_profile'),
Expand Down
8 changes: 0 additions & 8 deletions debug_toolbar/views.py
Expand Up @@ -23,14 +23,6 @@ def __str__(self):
return repr(self.value)


def debug_media(request, path):
root = getattr(settings, 'DEBUG_TOOLBAR_MEDIA_ROOT', None)
if root is None:
parent = os.path.abspath(os.path.dirname(__file__))
root = os.path.join(parent, 'media', 'debug_toolbar')
return django.views.static.serve(request, path, root)


def sql_select(request):
"""
Returns the output of the SQL SELECT statement.
Expand Down
2 changes: 2 additions & 0 deletions example/settings.py
Expand Up @@ -17,6 +17,8 @@
INTERNAL_IPS = ('127.0.0.1',)
MEDIA_ROOT = os.path.join(PROJECT_PATH, 'media')
MEDIA_URL = '/media'
STATIC_ROOT = os.path.join(HOME_ROOT, 'staticfiles')
STATIC_URL = '/static/'
MIDDLEWARE_CLASSES = (
'django.middleware.common.CommonMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion example/templates/jquery/index.html
Expand Up @@ -6,7 +6,7 @@
.hide {display:none;}
#v {font-weight:bold;}
</style>
<script type="text/javascript" charset="utf-8" src="{{ MEDIA_URL }}/js/jquery.js"></script>
<script type="text/javascript" charset="utf-8" src="{{ STATIC_URL }}/js/jquery.js"></script>
<script type="text/javascript">
$(document).ready(function() {
$('p.hide').show();
Expand Down
2 changes: 1 addition & 1 deletion example/templates/mootools/index.html
Expand Up @@ -5,7 +5,7 @@
<style>
.hide {display:none;}
</style>
<script type="text/javascript" charset="utf-8" src="{{ MEDIA_URL }}/js/mootools.js"></script>
<script type="text/javascript" charset="utf-8" src="{{ STATIC_URL }}/js/mootools.js"></script>
<script type="text/javascript">
window.addEvent('domready', function() {
$$('p.hide').setStyle('display', 'block');
Expand Down
2 changes: 1 addition & 1 deletion example/templates/prototype/index.html
Expand Up @@ -5,7 +5,7 @@
<style>
.hide {display:none;}
</style>
<script type="text/javascript" charset="utf-8" src="{{ MEDIA_URL }}/js/prototype.js"></script>
<script type="text/javascript" charset="utf-8" src="{{ STATIC_URL }}/js/prototype.js"></script>
<script type="text/javascript">
document.observe('dom:loaded', function() {
$('showme').removeClassName('hide');
Expand Down

0 comments on commit 20e9253

Please sign in to comment.