When page deleted, delete its shortcodes. Fix #4.

shortcodes/signals.py

@@ -1,4 +1,4 @@
-from django.db.models.signals import pre_save
+from django.db.models.signals import pre_save, pre_delete
 
 from mezzanine.core.models import RichText
 
@@ -54,5 +54,11 @@ def on_save(sender, **kwargs):
         _delete_tags(old_tags.difference(tags))
 
 
+def on_delete(sender, **kwargs):
+    # Delete all associated shortcode model instances.
+    _delete_tags(ShortcodeSoup(kwargs['instance'].content).find_shortcodes())
+
+
 for subclass in _get_subclasses(RichText):
     pre_save.connect(on_save, subclass)
+    pre_delete.connect(on_delete, subclass)

test/test_browser.py

@@ -344,6 +344,17 @@ def test_remove_after_saving(self):
             self.jQueryContent(".find('body').empty().append('blah')")
             self.savePage()
 
+    def test_remove_after_deleting(self):
+        """
+        When a page is deleted, all associated shortcodes are deleted too.
+        """
+        self.insertFeaturefulButton()
+        self.savePage()
+
+        with self.assertDeletesInstance(FeaturefulButton):
+            self.browser.find_by_text('Delete').click()
+            self.browser.find_by_value("Yes, I'm sure").click()
+
     @unittest.skipIf(WEBDRIVER == 'phantomjs', "Can't open dialog.")
     def test_icon(self):
         self.browser.execute_script("""\